From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 46F60C376 for ; Thu, 18 Feb 2016 14:55:34 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 18 Feb 2016 05:55:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,465,1449561600"; d="scan'208";a="888668418" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga001.jf.intel.com with ESMTP; 18 Feb 2016 05:55:32 -0800 Date: Thu, 18 Feb 2016 21:56:03 +0800 From: Yuanhan Liu To: Panu Matilainen Message-ID: <20160218135603.GO21426@yliu-dev.sh.intel.com> References: <20160218132549.GN21426@yliu-dev.sh.intel.com> <56C5C98E.7010205@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56C5C98E.7010205@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 13:55:34 -0000 On Thu, Feb 18, 2016 at 03:39:26PM +0200, Panu Matilainen wrote: > On 02/18/2016 03:25 PM, Yuanhan Liu wrote: > >On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote: > >>Commit d0cf91303d73 added dependency on librte_net headers to vhost > >>but did not add this to the Makefile, which makes builds > >>non-deterministic. Curiously it is non-parallel build that is > >>consistently broken by this missing dependency, usually it's the other > >>way around, but trying to build without -j(n) fails with: > > > >Yeah, I have confirmed it; I was wondering why I didn't meet such build > >error. > > > >> > >> dpdk/lib/librte_vhost/vhost_rxtx.c:41:20: > >> fatal error: rte_ip.h: No such file or directory > >> > >>Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities") > >>Signed-off-by: Panu Matilainen > > > >Acked-by: Yuanhan Liu > > > >Thanks. > > > >BTW, please cc me for virtio/vhost patches next time, otherwise, it's > >easily got overlooked: too many emails. > > Hmm, I thought I did. Looking more carefully now, I mixed up the patch > author (who was CC'd) with you: I didn't see the author was cc'ed from my email client: Date: Thu, 18 Feb 2016 11:47:43 +0200 From: Panu Matilainen To: dev@dpdk.org Subject: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net > > commit d0cf91303d731997945420832ee245b21f292e19 > Author: Jijiang Liu > > I hate it when people call me Paul (commonly happens) just because it Hmm... I didn't call you that, right? > vaguely resembles my name, Indeed :) > so I really should do better than this. > Apologies, I'll pay closer attention in the future. Never mind, it's not a big deal. Emails with me CC'ed are highlighted in my mutt email client, therefore, it's unlikely I will miss them. --yliu