From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zhe.tao@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id D32016A6F
 for <dev@dpdk.org>; Tue, 23 Feb 2016 04:48:42 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga103.fm.intel.com with ESMTP; 22 Feb 2016 19:48:39 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,487,1449561600"; d="scan'208";a="909060508"
Received: from adambynes.sh.intel.com (HELO adambynes) ([10.239.129.240])
 by fmsmga001.fm.intel.com with ESMTP; 22 Feb 2016 19:48:34 -0800
Date: Tue, 23 Feb 2016 11:48:23 +0800
From: Zhe Tao <zhe.tao@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Message-ID: <20160223034823.GA48315@intel.com>
References: <1453358984-20550-1-git-send-email-zhe.tao@intel.com>
 <9BB6961774997848B5B42BEC655768F8DA85F6@SHSMSX103.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9BB6961774997848B5B42BEC655768F8DA85F6@SHSMSX103.ccr.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: add VEB switching support for i40e
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Feb 2016 03:48:43 -0000

On Fri, Feb 19, 2016 at 01:17:41PM +0800, Wu, Jingjing wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhe Tao
> > Sent: Thursday, January 21, 2016 2:50 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] i40e: add VEB switching support for i40e
> > 
> > VEB switching feature for i40e is used to enable the switching between the
> >  VSIs connect to the virtual bridge. The old implementation is setting the
> >  virtual bridge mode as VEPA which is port aggregation. Enable the switching
> >  ability by setting the loop back mode for the specific VSIs which connect to PF
> >  or VFs.
> 
> As I know, there is a known issue about the veb switch on older NVM version.
> I would be better to add a NVM version verification, if version > xx.xx, then enable it?
> 
> Thanks
> Jingjing
> 
Great suggestion, i will add the check for it!
Thanks
Zhe Tao
> > Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> > ---
> >  drivers/net/i40e/i40e_ethdev.c | 48 +++++++++++++++++++++++++++++++++++-------
> >  1 file changed, 40 insertions(+), 8 deletions(-)
> >