From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 8D25F298F
 for <dev@dpdk.org>; Wed, 24 Feb 2016 15:41:16 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga104.fm.intel.com with ESMTP; 24 Feb 2016 06:40:59 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,494,1449561600"; d="scan'208";a="893678958"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.64])
 by orsmga001.jf.intel.com with SMTP; 24 Feb 2016 06:40:57 -0800
Received: by  (sSMTP sendmail emulation); Wed, 24 Feb 2016 14:40:56 +0025
Date: Wed, 24 Feb 2016 14:40:56 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Message-ID: <20160224144056.GE19616@bricha3-MOBL3>
References: <cover.1454408702.git.rahul.lakkireddy@chelsio.com>
 <2131fd9284f6b25cdbb4c7885354856f4ff2ebe5.1454408702.git.rahul.lakkireddy@chelsio.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2131fd9284f6b25cdbb4c7885354856f4ff2ebe5.1454408702.git.rahul.lakkireddy@chelsio.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org, Kumar Sanghvi <kumaras@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH 02/10] examples/test-cxgbe-filters: add
 example to test cxgbe fdir support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Feb 2016 14:41:17 -0000

On Wed, Feb 03, 2016 at 02:02:23PM +0530, Rahul Lakkireddy wrote:
> Add a new test_cxgbe_filters command line example to test support for
> Chelsio T5 hardware filtering. Shows how to pass the Chelsio input flow
> and input masks. Also, shows how to pass extra behavior arguments to
> rewrite fields in matched filter rules.
> 
> Also add documentation and update MAINTAINERS.
> 
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>

Hi,

for testing NIC functionality, the "testpmd" app is what is used, and it already
contains support for existing flow director functionality. Should the testing
functionality not be included there?

Note: that's not to say we don't need a simple example app as well, for 
demonstrating how to use flow director, but at minimum for nic features we
generally need to have testpmd support.

Can this patchset perhaps be changed to include some testpmd support, and maybe
have any example apps as a separate set?

Regards,
/Bruce