From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from stargate3.asicdesigners.com (stargate.chelsio.com [12.32.117.8]) by dpdk.org (Postfix) with ESMTP id A32C62BF9 for ; Wed, 24 Feb 2016 19:35:56 +0100 (CET) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate3.asicdesigners.com (8.13.8/8.13.8) with ESMTP id u1OIZpRX002977; Wed, 24 Feb 2016 10:35:52 -0800 Date: Thu, 25 Feb 2016 00:05:34 +0530 From: Rahul Lakkireddy To: Bruce Richardson Message-ID: <20160224183532.GA8856@chelsio.com> References: <2131fd9284f6b25cdbb4c7885354856f4ff2ebe5.1454408702.git.rahul.lakkireddy@chelsio.com> <20160224144056.GE19616@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160224144056.GE19616@bricha3-MOBL3> User-Agent: Mutt/1.5.24 (2015-08-30) Cc: "dev@dpdk.org" , Kumar A S , Nirranjan Kirubaharan Subject: Re: [dpdk-dev] [PATCH 02/10] examples/test-cxgbe-filters: add example to test cxgbe fdir support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 18:35:57 -0000 Hi Bruce, On Wednesday, February 02/24/16, 2016 at 06:40:56 -0800, Bruce Richardson wrote: > On Wed, Feb 03, 2016 at 02:02:23PM +0530, Rahul Lakkireddy wrote: > > Add a new test_cxgbe_filters command line example to test support for > > Chelsio T5 hardware filtering. Shows how to pass the Chelsio input flow > > and input masks. Also, shows how to pass extra behavior arguments to > > rewrite fields in matched filter rules. > > > > Also add documentation and update MAINTAINERS. > > > > Signed-off-by: Rahul Lakkireddy > > Signed-off-by: Kumar Sanghvi > > Hi, > > for testing NIC functionality, the "testpmd" app is what is used, and it already > contains support for existing flow director functionality. Should the testing > functionality not be included there? > We initially thought of adding example by extending flow director in testpmd itself. However, based on discussion at [1], we then created a separate sample app for this considering each vendor would come up with their own sample app. [1] http://permalink.gmane.org/gmane.comp.networking.dpdk.devel/31471 > Note: that's not to say we don't need a simple example app as well, for > demonstrating how to use flow director, but at minimum for nic features we > generally need to have testpmd support. > > Can this patchset perhaps be changed to include some testpmd support, and maybe > have any example apps as a separate set? > If adding example in the existing testpmd sounds more appropriate then, I will re-submit by updating testpmd instead. Thanks, Rahul