From: Bruce Richardson <bruce.richardson@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] nfp: fix non-x86 build
Date: Wed, 2 Mar 2016 21:10:38 +0000 [thread overview]
Message-ID: <20160302211037.GA8804@bricha3-MOBL3> (raw)
In-Reply-To: <CAD+H992-6itQzGgXJmrep1nLaitkjVmLUxQ6b+eUbOcf-AjOOA@mail.gmail.com>
On Mon, Feb 08, 2016 at 02:27:59PM +0000, Alejandro Lucero wrote:
> On Sat, Feb 6, 2016 at 9:51 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
>
> > The file sys/io.h was included but it can be unavailable in some
> > non-x86 toolchains.
> > As others system includes in the file nfp_net.c, it seems useless,
> > so the easy fix is to remove them.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> > drivers/net/nfp/nfp_net.c | 11 -----------
> > 1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> > index bc2089f..283269e 100644
> > --- a/drivers/net/nfp/nfp_net.c
> > +++ b/drivers/net/nfp/nfp_net.c
> > @@ -39,18 +39,7 @@
> > * Netronome vNIC DPDK Poll-Mode Driver: Main entry point
> > */
> >
> > -#include <stdio.h>
> > -#include <stdlib.h>
> > -#include <stdint.h>
> > -#include <unistd.h>
> > -#include <string.h>
> > -#include <sys/mman.h>
> > -#include <sys/socket.h>
> > -#include <sys/io.h>
> > -#include <assert.h>
> > -#include <time.h>
> > #include <math.h>
> > -#include <inttypes.h>
> >
> > #include <rte_byteorder.h>
> > #include <rte_common.h>
> > --
> > 2.7.0
> >
> >
> This is fine for me.
>
> Thanks
Applied to dpdk-next-net/rel_16_04 with Alejandro's ack
/Bruce
prev parent reply other threads:[~2016-03-02 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 21:51 Thomas Monjalon
2016-02-08 14:27 ` Alejandro Lucero
2016-03-02 21:10 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302211037.GA8804@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).