* [dpdk-dev] [PATCH] nfp: fix non-x86 build
@ 2016-02-06 21:51 Thomas Monjalon
2016-02-08 14:27 ` Alejandro Lucero
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2016-02-06 21:51 UTC (permalink / raw)
To: alejandro.lucero; +Cc: dev
The file sys/io.h was included but it can be unavailable in some
non-x86 toolchains.
As others system includes in the file nfp_net.c, it seems useless,
so the easy fix is to remove them.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
drivers/net/nfp/nfp_net.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index bc2089f..283269e 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -39,18 +39,7 @@
* Netronome vNIC DPDK Poll-Mode Driver: Main entry point
*/
-#include <stdio.h>
-#include <stdlib.h>
-#include <stdint.h>
-#include <unistd.h>
-#include <string.h>
-#include <sys/mman.h>
-#include <sys/socket.h>
-#include <sys/io.h>
-#include <assert.h>
-#include <time.h>
#include <math.h>
-#include <inttypes.h>
#include <rte_byteorder.h>
#include <rte_common.h>
--
2.7.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] nfp: fix non-x86 build
2016-02-06 21:51 [dpdk-dev] [PATCH] nfp: fix non-x86 build Thomas Monjalon
@ 2016-02-08 14:27 ` Alejandro Lucero
2016-03-02 21:10 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Alejandro Lucero @ 2016-02-08 14:27 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Sat, Feb 6, 2016 at 9:51 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> The file sys/io.h was included but it can be unavailable in some
> non-x86 toolchains.
> As others system includes in the file nfp_net.c, it seems useless,
> so the easy fix is to remove them.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> drivers/net/nfp/nfp_net.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index bc2089f..283269e 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -39,18 +39,7 @@
> * Netronome vNIC DPDK Poll-Mode Driver: Main entry point
> */
>
> -#include <stdio.h>
> -#include <stdlib.h>
> -#include <stdint.h>
> -#include <unistd.h>
> -#include <string.h>
> -#include <sys/mman.h>
> -#include <sys/socket.h>
> -#include <sys/io.h>
> -#include <assert.h>
> -#include <time.h>
> #include <math.h>
> -#include <inttypes.h>
>
> #include <rte_byteorder.h>
> #include <rte_common.h>
> --
> 2.7.0
>
>
This is fine for me.
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] nfp: fix non-x86 build
2016-02-08 14:27 ` Alejandro Lucero
@ 2016-03-02 21:10 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2016-03-02 21:10 UTC (permalink / raw)
To: Alejandro Lucero; +Cc: dev
On Mon, Feb 08, 2016 at 02:27:59PM +0000, Alejandro Lucero wrote:
> On Sat, Feb 6, 2016 at 9:51 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
>
> > The file sys/io.h was included but it can be unavailable in some
> > non-x86 toolchains.
> > As others system includes in the file nfp_net.c, it seems useless,
> > so the easy fix is to remove them.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> > drivers/net/nfp/nfp_net.c | 11 -----------
> > 1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> > index bc2089f..283269e 100644
> > --- a/drivers/net/nfp/nfp_net.c
> > +++ b/drivers/net/nfp/nfp_net.c
> > @@ -39,18 +39,7 @@
> > * Netronome vNIC DPDK Poll-Mode Driver: Main entry point
> > */
> >
> > -#include <stdio.h>
> > -#include <stdlib.h>
> > -#include <stdint.h>
> > -#include <unistd.h>
> > -#include <string.h>
> > -#include <sys/mman.h>
> > -#include <sys/socket.h>
> > -#include <sys/io.h>
> > -#include <assert.h>
> > -#include <time.h>
> > #include <math.h>
> > -#include <inttypes.h>
> >
> > #include <rte_byteorder.h>
> > #include <rte_common.h>
> > --
> > 2.7.0
> >
> >
> This is fine for me.
>
> Thanks
Applied to dpdk-next-net/rel_16_04 with Alejandro's ack
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-02 21:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-06 21:51 [dpdk-dev] [PATCH] nfp: fix non-x86 build Thomas Monjalon
2016-02-08 14:27 ` Alejandro Lucero
2016-03-02 21:10 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).