Re: [dpdk-dev] [PATCH v3 00/30] i40e base driver update

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Feb 18, 2016 at 10:34:06PM +0800, Helin Zhang wrote:
> i40e base driver is updated, to support new X722 device IDs, and
> use rx control AQ commands to read/write rx control registers.
> Of cause, fixes and enhancements are added as listed as below.
> 
> v3:
>  - As release_2_3.rst has been renamed to release_16_04.rst, then
>    all modifications in release_2_3.rst should be moved into
>    release_16_04.rst.
> 
> v2:
>  - Used i40e_set_mac_type() in base driver to replace the similar
>    in PMD source files, in order to support newly added X722 VF
>    device IDs.
>  - Used small letter in all commit log titles.
>
Hi Helin,

I've scanned through this patchset with a view to merge, looking in particular
at the commit titles and commit descriptions. Some overall points keep coming
up:

* a lot of the title look too long. 50 characters is the recommended max length
* some of the patches look to be fixing issues. Please start the titles of those
with the word "fix" and include a "fixes" line in the message.
* some of the titles are of the form "do X and do Y", which implies that the
patch may need to be split into two separate patches.

>From the descriptions of the patches, patches 28 and 9, and 29 and 22 seem to be
doing the same thing. Can you merge these patches if necessary, otherwise please
clarify what the differences between them are.

Can you please clean these things up and resubmit?

Thanks,
/Bruce