From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3CC6A2BBB for ; Thu, 3 Mar 2016 21:37:01 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 03 Mar 2016 12:36:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,533,1449561600"; d="scan'208";a="757679579" Received: from bricha3-mobl3.ger.corp.intel.com ([10.122.33.80]) by orsmga003.jf.intel.com with SMTP; 03 Mar 2016 12:36:47 -0800 Received: by (sSMTP sendmail emulation); Thu, 03 Mar 2016 20:36:47 +0025 Date: Thu, 3 Mar 2016 20:36:46 +0000 From: Bruce Richardson To: Helin Zhang Message-ID: <20160303203645.GA11544@bricha3-MOBL3> References: <1455776683-11790-1-git-send-email-helin.zhang@intel.com> <1455806076-18497-1-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455806076-18497-1-git-send-email-helin.zhang@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 00/30] i40e base driver update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 20:37:02 -0000 On Thu, Feb 18, 2016 at 10:34:06PM +0800, Helin Zhang wrote: > i40e base driver is updated, to support new X722 device IDs, and > use rx control AQ commands to read/write rx control registers. > Of cause, fixes and enhancements are added as listed as below. > > v3: > - As release_2_3.rst has been renamed to release_16_04.rst, then > all modifications in release_2_3.rst should be moved into > release_16_04.rst. > > v2: > - Used i40e_set_mac_type() in base driver to replace the similar > in PMD source files, in order to support newly added X722 VF > device IDs. > - Used small letter in all commit log titles. > Hi Helin, I've scanned through this patchset with a view to merge, looking in particular at the commit titles and commit descriptions. Some overall points keep coming up: * a lot of the title look too long. 50 characters is the recommended max length * some of the patches look to be fixing issues. Please start the titles of those with the word "fix" and include a "fixes" line in the message. * some of the titles are of the form "do X and do Y", which implies that the patch may need to be split into two separate patches. >>From the descriptions of the patches, patches 28 and 9, and 29 and 22 seem to be doing the same thing. Can you merge these patches if necessary, otherwise please clarify what the differences between them are. Can you please clean these things up and resubmit? Thanks, /Bruce