From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 6FDC42B96 for ; Fri, 4 Mar 2016 19:17:19 +0100 (CET) Received: by mail-pf0-f182.google.com with SMTP id 4so39320724pfd.1 for ; Fri, 04 Mar 2016 10:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ue9p+WIxvl3hDgdbCV+uEqm3Bm/D/d1DHmVSm11yg6E=; b=jKo2V4ciM95nFVNBNT4zeJ5cNkphRJvkFaaIBbItE7oxlnJWLuJBks9TJpScswS+Os WEo7RptliRzlWvYsXnwn6V8TkZ/L3skoPvAg/7/f1tScesfsmh8VzpYnn+G0kLUpYJYC psOy4Qfila2Mt0ca86uorYNvYIDx5ZmWfm/0sqZORqJz9My5Q7oWwnNFjWXiaNzGRSko vP9ml5REb2qZUweb8BTBNsUO4K0DHrTX6iZxHwgEzYXPMdZB9kQ40F8pBoWKVis44ud+ EpshZCgGMaJvXW9pkZsENfvlKMfc4tuFyxjjGmShrk6ZFqMw3IFyJvcBEYENZBeguT53 JjNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ue9p+WIxvl3hDgdbCV+uEqm3Bm/D/d1DHmVSm11yg6E=; b=SWadcjfwKY8hLyiNCs8hzzupnrrEPt45CrJGdBCFwfoGeSrpPLUVchdmLXQsNG47VB x2qGIExpfja3bjhMumjk8wf2/APB/LU77e/8fjA2tUyjFApK48HAEiuHIG81Yh0F2oFA S9NR+Cw1KFAS2+iKQ+HBLigZpXKKeTb+EHbJD/lV1NjvJGLW9DwBPJEvR0vTbARaL82u 9em6nF1qkLLOARinobTDbkHW3Pi/2OUqCg+HAEtXazo8opFiqBpSQzt/LNJwzHljK8bm i1+tTedEfxDoxjnUvTSWj5Oq7EOfmK1acTF11Hy1FoKYavgZ/gVGjX5zVzHIjm3/PZ5k ST3g== X-Gm-Message-State: AD7BkJKSerQP20WHDSH0USCY1Hj7naLcakHjHfXwrk9UQjpsm9xZn7dh+Ssy/ne3azhznQ== X-Received: by 10.98.32.150 with SMTP id m22mr13988887pfj.27.1457115438854; Fri, 04 Mar 2016 10:17:18 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id 82sm7034485pfi.78.2016.03.04.10.17.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Mar 2016 10:17:18 -0800 (PST) Date: Fri, 4 Mar 2016 10:17:32 -0800 From: Stephen Hemminger To: "Xie, Huawei" Message-ID: <20160304101732.144d8901@xeon-e3> In-Reply-To: References: <1445231772-17467-1-git-send-email-stephen@networkplumber.org> <2330408.2AHZ8BdDek@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 0/5] virtio: Tx performance improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 18:17:19 -0000 On Fri, 4 Mar 2016 06:18:17 +0000 "Xie, Huawei" wrote: > On 1/14/2016 9:49 PM, Xie, Huawei wrote: > > On 1/6/2016 8:04 PM, Thomas Monjalon wrote: > >> 2016-01-05 08:10, Xie, Huawei: > >>> On 10/26/2015 10:06 PM, Xie, Huawei wrote: > >>>> On 10/19/2015 1:16 PM, Stephen Hemminger wrote: > >>>>> This is a tested version of the virtio Tx performance improvements > >>>>> that I posted earlier on the list, and described at the DPDK Userspace > >>>>> meeting in Dublin. Together they get a 25% performance improvement for > >>>>> both small packet and large multi-segment packet case when testing > >>>>> from DPDK guest application to Linux KVM host. > >>>>> > >>>>> Stephen Hemminger (5): > >>>>> virtio: clean up space checks on xmit > >>>>> virtio: don't use unlikely for normal tx stuff > >>>>> virtio: use indirect ring elements > >>>>> virtio: use any layout on transmit > >>>>> virtio: optimize transmit enqueue > >>>> There is one open why merge-able header is used in tx path. Since old > >>>> implementation is also using the merge-able header in tx path if this > >>>> feature is negotiated, i choose to ack the patch and address this later > >>>> if not now. > >>>> > >>>> Acked-by: Huawei Xie > >>> Thomas: Resending them now. I don't understand the issue with merge-able header. Virtio negotiation is symmetric, if receiver is using merge-able header then the transmitter needs to send it also.