From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 58D702B96
 for <dev@dpdk.org>; Wed,  9 Mar 2016 19:28:18 +0100 (CET)
Received: by mail-pf0-f182.google.com with SMTP id u190so17780364pfb.3
 for <dev@dpdk.org>; Wed, 09 Mar 2016 10:28:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:subject:message-id:mime-version
 :content-transfer-encoding;
 bh=67QPq3rTU8mtDbJDjwCscY4t0R0ceX5OGmVDfT2LABM=;
 b=rFKIrdycWvBjo35+SSyRYC09LoxaC8OwxYvV9cIMfnw2blYsOq6K6eS2urb3F+Nyqf
 eEGJE2bCyGBkItM//x7YCjaVZ7svonrRzL88n4sLT88I3JtZe1Xoyr3BiMd6MxxaQ5jJ
 fu1iS/OmY3Qaawvs+dbyvBuXN7E3d+FJT+nuk/EMxw/DhbIPD6w/lS8t7j7zoH8/+gOV
 wGE4n0DfxTQeXedxFA1o6cmAZafX6PuH1X+6XZifJfVBaGjv4QsPXgZGZLkDl5eSHsxJ
 5Q38Sa4b/zymmE+d0fASFPk3Ki5vTTblD6b5ce/uFJK3X65QPhmdGkNRRVvCWOQJcsEw
 5h+w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:subject:message-id:mime-version
 :content-transfer-encoding;
 bh=67QPq3rTU8mtDbJDjwCscY4t0R0ceX5OGmVDfT2LABM=;
 b=PZlHc6NyowSC0xX4tfvPZvsIzmgjre2hAAFcClYDbHqsWuUEAXTljgjt+DrZI4Mox0
 aPp4sYASm641NTGFv207eZoZH2Oye0+O2LhvfUrbZVTn4Jv6OU61brxKgvA7wyCUL8RH
 tqq4U9aCNKgP8suOtxKJEc+SHQUo0Imq79r9T46MH/XSKp5kw01o0HAj+5tWwFvPPzfG
 RHrPGaPyGvS9XsJpyYYpN0EBWhYXREkc9E1HnKMds4bafDj4ffBTZBAzntw4YH6QA4cw
 If6KgYziuBjya/UO5aArBAZhWnpv46IsfTbBA8inWC1+RNHGnSMHwbOwaWdEpQS6F0lY
 qWWg==
X-Gm-Message-State: AD7BkJLfwvdzkJhWFsPFj4e+t+ynll/EUVSw4QUMjtqVCqzvo0k+BbEHxQafajEc5nvMbQ==
X-Received: by 10.98.67.139 with SMTP id l11mr38946085pfi.112.1457548097730;
 Wed, 09 Mar 2016 10:28:17 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id r68sm13973001pfa.33.2016.03.09.10.28.17
 for <dev@dpdk.org>
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 09 Mar 2016 10:28:17 -0800 (PST)
Date: Wed, 9 Mar 2016 10:28:26 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Message-ID: <20160309102826.2a1dcc7b@xeon-e3>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [dpdk-dev] don't use printf!
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2016 18:28:18 -0000

One thing I noticed while fixing mempool bug, was that there was a printf
in the library there. A reminder, code in DPDK library should never call printf
directly. printf in a real application is often ratholed off to /dev/null
and real output is through API's or syslog.

Offenders now:
 rte_mempool
 rte_acl
 rte_cfgfile

I would fix rte_acl but it would require API breakage.
rte_acl_dump should take a FILE *


Some places have printf in debug path, which is less bad, but
still limits usage of DEBUG options
 rte_sched
 rte_timer

There are also several places in the BSD support, but I care less about those.