From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 9C5352BAB
 for <dev@dpdk.org>; Thu, 10 Mar 2016 08:48:13 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 09 Mar 2016 23:48:13 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,314,1455004800"; d="scan'208";a="933650807"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49])
 by fmsmga002.fm.intel.com with ESMTP; 09 Mar 2016 23:48:12 -0800
Date: Thu, 10 Mar 2016 15:50:54 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: David Marchand <david.marchand@6wind.com>
Message-ID: <20160310075054.GH979@yliu-dev.sh.intel.com>
References: <1457593280-25412-1-git-send-email-yuanhan.liu@linux.intel.com>
 <CALwxeUvJwDUNmparc3hT=8SJz1r36LZm6Z9_fFD_rFssuD7nnA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALwxeUvJwDUNmparc3hT=8SJz1r36LZm6Z9_fFD_rFssuD7nnA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] virtio: fix wrong features returned for
	legacy virtio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2016 07:48:14 -0000

On Thu, Mar 10, 2016 at 08:43:37AM +0100, David Marchand wrote:
> On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu
> <yuanhan.liu@linux.intel.com> wrote:
> > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get
> > a random upper 32 bit feature bits, as the following io port read reads
> > lower 32 bit only. It could lead a feature bits that include VIRTIO_F_VERSION_1
> > (the 32th bit) for legacy virtio, which is obviously wrong.
> >
> > Fixes: b8f04520ad71 ("virtio: use PCI ioport API")
> >
> > Cc: David Marchand <david.marchand@6wind.com>
> > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> 
> Argh, good catch.
> Relooked at my patch, this should be the only bug (of this kind ;-)).

Yes, I also have a check while making this patch.

	--yliu
> 
> Reviewed-by: David Marchand <david.marchand@6wind.com>
> 
> 
> -- 
> David Marchand