From: Bruce Richardson <bruce.richardson@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Charles \(Chas\) Williams" <ciwillia@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()
Date: Thu, 10 Mar 2016 10:33:27 +0000 [thread overview]
Message-ID: <20160310103326.GC14712@bricha3-MOBL3> (raw)
In-Reply-To: <2552F74A0BCCBE4DBE2AD218C81B2811086B1525@avmb3.qlogic.org>
On Fri, Mar 04, 2016 at 10:28:44PM +0000, Rasesh Mody wrote:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chas Williams
> > Sent: Wednesday, December 30, 2015 4:38 PM
> >
> > From: "Charles (Chas) Williams" <ciwillia@brocade.com>
> >
> > bnx2x_loop_obtain_resources() returns a struct containing the status and
> > the error message. If bnx2x_do_req4pf() fails, it shouldn't return both of
> > these fields set to 0 indicating failure and no error.
> >
> > Further, bnx2x_do_req4pf() needs to be able fail and return NO_RESOURCES
> > so that bnx2x_loop_obtain_resources() can negotiate reduced resource
> > requirments. This requires additional checking around bnx2x_do_req4pf().
> >
> > Signed-off-by: Chas Williams <3chas3@gmail.com>
> > ---
>
> Acked-by: Rasesh Mody <rasesh.mody@qlogic.com>
>
> The change looks good.
>
> Thanks!
> Rasesh
>
Applied to dpdk-next-net/rel_16_04, with added fixes line in message.
/Bruce
prev parent reply other threads:[~2016-03-10 10:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 0:37 Chas Williams
2015-12-31 0:37 ` [dpdk-dev] [PATCH 2/2] bnx2x: Determine rx/tx queue sizes sooner Chas Williams
2016-03-04 22:28 ` Rasesh Mody
2016-03-10 10:32 ` Bruce Richardson
2016-02-08 13:51 ` [dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources() Bruce Richardson
2016-02-08 15:53 ` Charles (Chas) Williams
2016-02-08 16:03 ` Bruce Richardson
2016-03-04 22:28 ` Rasesh Mody
2016-03-10 10:33 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310103326.GC14712@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=ciwillia@brocade.com \
--cc=dev@dpdk.org \
--cc=rasesh.mody@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).