From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 6E2992946
 for <dev@dpdk.org>; Thu, 10 Mar 2016 11:33:31 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga101.jf.intel.com with ESMTP; 10 Mar 2016 02:33:30 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,315,1455004800"; d="scan'208";a="761555495"
Received: from ugavish-mobl1.ger.corp.intel.com ([10.252.20.226])
 by orsmga003.jf.intel.com with SMTP; 10 Mar 2016 02:33:28 -0800
Received: by  (sSMTP sendmail emulation); Thu, 10 Mar 2016 10:33:27 +0025
Date: Thu, 10 Mar 2016 10:33:27 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Message-ID: <20160310103326.GC14712@bricha3-MOBL3>
References: <1451522271-16924-1-git-send-email-3chas3@gmail.com>
 <2552F74A0BCCBE4DBE2AD218C81B2811086B1525@avmb3.qlogic.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2552F74A0BCCBE4DBE2AD218C81B2811086B1525@avmb3.qlogic.org>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "Charles \(Chas\) Williams" <ciwillia@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in
 bnx2x_loop_obtain_resources()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2016 10:33:31 -0000

On Fri, Mar 04, 2016 at 10:28:44PM +0000, Rasesh Mody wrote:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chas Williams
> > Sent: Wednesday, December 30, 2015 4:38 PM
> > 
> > From: "Charles (Chas) Williams" <ciwillia@brocade.com>
> > 
> > bnx2x_loop_obtain_resources() returns a struct containing the status and
> > the error message.  If bnx2x_do_req4pf() fails, it shouldn't return both of
> > these fields set to 0 indicating failure and no error.
> > 
> > Further, bnx2x_do_req4pf() needs to be able fail and return NO_RESOURCES
> > so that bnx2x_loop_obtain_resources() can negotiate reduced resource
> > requirments.  This requires additional checking around bnx2x_do_req4pf().
> > 
> > Signed-off-by: Chas Williams <3chas3@gmail.com>
> > ---
> 
> Acked-by: Rasesh Mody <rasesh.mody@qlogic.com>
> 
> The change looks good.
> 
> Thanks!
> Rasesh
> 

Applied to dpdk-next-net/rel_16_04, with added fixes line in message.

/Bruce