[dpdk-dev] [PATCH] doc: add mempool mgr ABI deprication notice

[dpdk-dev] [PATCH] doc: add mempool mgr ABI deprication notice

[David Hunt]

Announce the ABI breakage due to addition of external mempool
manager functionality which requires changes to rte_mempool
structure.

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 9930b5a..263e652 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -39,3 +39,13 @@ Deprecation Notices
   and table action handlers will be updated:
   the pipeline parameter will be added, the packets mask parameter will be
   either removed (for input port action handler) or made input-only.
+
+* librte_mempool: The rte_mempool struct will be changed in 16.07 to
+  facilitate the new external mempool manager functionality.
+  The ring element will be replaced with a more generic 'pool' opaque pointer
+  to allow new mempool handlers to use their own user-defined mempool
+  layout. Also newly added to rte_mempool is a handler index.
+  The existing API will be backward compatible, but there will be new API
+  functions added to facilitate the creation of mempools using an external
+  handler. The 16.07 release will contain these changes.
+
-- 
2.5.0

Re: [dpdk-dev] [PATCH] doc: add mempool mgr ABI deprication notice

[Olivier MATZ]

Hi David,

On 03/10/2016 12:55 PM, David Hunt wrote:
> Announce the ABI breakage due to addition of external mempool
> manager functionality which requires changes to rte_mempool
> structure.
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Please note we need not 2 more acks for this kind of deprecation
notices.

Thanks,
Olivier

Re: [dpdk-dev] [PATCH] doc: add mempool mgr ABI deprication notice

[Bruce Richardson]

On Thu, Mar 10, 2016 at 01:37:27PM +0100, Olivier MATZ wrote:
> Hi David,
> 
> On 03/10/2016 12:55 PM, David Hunt wrote:
> > Announce the ABI breakage due to addition of external mempool
> > manager functionality which requires changes to rte_mempool
> > structure.
> > 
> > Signed-off-by: David Hunt <david.hunt@intel.com>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

/Bruce

Re: [dpdk-dev] [PATCH] doc: add mempool mgr ABI deprication notice

[Wiles, Keith]

>On Thu, Mar 10, 2016 at 01:37:27PM +0100, Olivier MATZ wrote:
>> Hi David,
>> 
>> On 03/10/2016 12:55 PM, David Hunt wrote:
>> > Announce the ABI breakage due to addition of external mempool
>> > manager functionality which requires changes to rte_mempool
>> > structure.
>> > 
>> > Signed-off-by: David Hunt <david.hunt@intel.com>
>> 
>> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>> 
>Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Asked-by: Keith Wiles <keith.wiles@intel.com>
>
>/Bruce
>


Regards,
Keith

Re: [dpdk-dev] [PATCH] doc: add mempool mgr ABI deprication notice

[Thomas Monjalon]

2016-03-10 13:56, Wiles, Keith:
> >On Thu, Mar 10, 2016 at 01:37:27PM +0100, Olivier MATZ wrote:
> >> Hi David,
> >> 
> >> On 03/10/2016 12:55 PM, David Hunt wrote:
> >> > Announce the ABI breakage due to addition of external mempool
> >> > manager functionality which requires changes to rte_mempool
> >> > structure.
> >> > 
> >> > Signed-off-by: David Hunt <david.hunt@intel.com>
> >> 
> >> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> >> 
> >Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Asked-by: Keith Wiles <keith.wiles@intel.com>

Is it on purpose, Keith, or a typo? Do you have asked this notice?

Re: [dpdk-dev] [PATCH] doc: add mempool mgr ABI deprication notice

[Wiles, Keith]

>2016-03-10 13:56, Wiles, Keith:
>> >On Thu, Mar 10, 2016 at 01:37:27PM +0100, Olivier MATZ wrote:
>> >> Hi David,
>> >> 
>> >> On 03/10/2016 12:55 PM, David Hunt wrote:
>> >> > Announce the ABI breakage due to addition of external mempool
>> >> > manager functionality which requires changes to rte_mempool
>> >> > structure.
>> >> > 
>> >> > Signed-off-by: David Hunt <david.hunt@intel.com>
>> >> 
>> >> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>> >> 
>> >Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>> 
>> Asked-by: Keith Wiles <keith.wiles@intel.com>
>
>Is it on purpose, Keith, or a typo? Do you have asked this notice?

Sorry, autocorrect :-(

Acked-by: Keith Wiles <keith.wiles@intel.com>
>
>


Regards,
Keith

Re: [dpdk-dev] [PATCH] doc: add mempool mgr ABI deprication notice

[Thomas Monjalon]

> >> > Announce the ABI breakage due to addition of external mempool
> >> > manager functionality which requires changes to rte_mempool
> >> > structure.
> >> > 
> >> > Signed-off-by: David Hunt <david.hunt@intel.com>
> >> 
> >> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> >> 
> >Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>
> Asked-by: Keith Wiles <keith.wiles@intel.com>

Assumed it is an ack.
Applied, thanks

Re: [dpdk-dev] [PATCH] doc: add mempool mgr ABI deprication notice

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
> Sent: Thursday, March 10, 2016 11:56 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: add mempool mgr ABI deprication notice
> 
> Announce the ABI breakage due to addition of external mempool manager
> functionality which requires changes to rte_mempool structure.
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>