Re: [dpdk-dev] [PATCH v7 01/11] ethdev: add API to query packet type filling info

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Mar 10, 2016 at 03:31:25AM +0800, Jianfeng Tan wrote:
> Add a new API rte_eth_dev_get_ptype_info to query whether/what packet
> type can be filled by given already started device or its pmd rx burst
> function has already been decided).
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
>  doc/guides/rel_notes/release_16_04.rst |  3 +++
>  lib/librte_ether/rte_ethdev.c          | 26 ++++++++++++++++++++++++++
>  lib/librte_ether/rte_ethdev.h          | 27 +++++++++++++++++++++++++++
>  lib/librte_ether/rte_ether_version.map |  8 ++++++++
>  4 files changed, 64 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_16_04.rst b/doc/guides/rel_notes/release_16_04.rst
> index aa9eabc..376ece5 100644
> --- a/doc/guides/rel_notes/release_16_04.rst
> +++ b/doc/guides/rel_notes/release_16_04.rst
> @@ -162,6 +162,9 @@ This section should contain API changes. Sample format:
>    handlers are updated: the pipeline parameter is added,
>    the packets mask parameter has been either removed or made input-only.
>  
> +* A new API ``rte_eth_dev_get_ptype_info`` is added to query what packet types
> +  can be filled by given already started device.
> +
>  

Do we fill in API additions into this section? No other patches add such
additions here - only changes. Therefore, I think this should be dropped from
the patch.

 <snip> 
>  /**
> + * Retrieve the packet type information of an Ethernet device.
> + *
> + * @note
> + *   Better to invoke this API after the device is already started or rx burst
> + *   function is decided, to obtain concise ptype information.

s/consise/correct/ ??

/Bruce