From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6D6FA3792 for ; Thu, 10 Mar 2016 15:28:08 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 10 Mar 2016 06:28:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,316,1455004800"; d="scan'208";a="667069214" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.166]) by FMSMGA003.fm.intel.com with SMTP; 10 Mar 2016 06:28:05 -0800 Received: by (sSMTP sendmail emulation); Thu, 10 Mar 2016 14:28:04 +0025 Date: Thu, 10 Mar 2016 14:28:04 +0000 From: Bruce Richardson To: Jianfeng Tan Message-ID: <20160310142804.GB18264@bricha3-MOBL3> References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com> <1457551895-12077-1-git-send-email-jianfeng.tan@intel.com> <1457551895-12077-2-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457551895-12077-2-git-send-email-jianfeng.tan@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 01/11] ethdev: add API to query packet type filling info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 14:28:09 -0000 On Thu, Mar 10, 2016 at 03:31:25AM +0800, Jianfeng Tan wrote: > Add a new API rte_eth_dev_get_ptype_info to query whether/what packet > type can be filled by given already started device or its pmd rx burst > function has already been decided). > > Signed-off-by: Jianfeng Tan > Acked-by: Konstantin Ananyev > Acked-by: Adrien Mazarguil > --- > doc/guides/rel_notes/release_16_04.rst | 3 +++ > lib/librte_ether/rte_ethdev.c | 26 ++++++++++++++++++++++++++ > lib/librte_ether/rte_ethdev.h | 27 +++++++++++++++++++++++++++ > lib/librte_ether/rte_ether_version.map | 8 ++++++++ > 4 files changed, 64 insertions(+) > > diff --git a/doc/guides/rel_notes/release_16_04.rst b/doc/guides/rel_notes/release_16_04.rst > index aa9eabc..376ece5 100644 > --- a/doc/guides/rel_notes/release_16_04.rst > +++ b/doc/guides/rel_notes/release_16_04.rst > @@ -162,6 +162,9 @@ This section should contain API changes. Sample format: > handlers are updated: the pipeline parameter is added, > the packets mask parameter has been either removed or made input-only. > > +* A new API ``rte_eth_dev_get_ptype_info`` is added to query what packet types > + can be filled by given already started device. > + > Do we fill in API additions into this section? No other patches add such additions here - only changes. Therefore, I think this should be dropped from the patch. > /** > + * Retrieve the packet type information of an Ethernet device. > + * > + * @note > + * Better to invoke this API after the device is already started or rx burst > + * function is decided, to obtain concise ptype information. s/consise/correct/ ?? /Bruce