DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Yoann Desmouceaux <ydesmouc@cisco.com>
Cc: dev@dpdk.org, johndale@cisco.om
Subject: Re: [dpdk-dev] [PATCH] enic: fix dma addr of outgoing packets
Date: Thu, 10 Mar 2016 21:32:58 +0000	[thread overview]
Message-ID: <20160310213257.GA19700@bricha3-MOBL3> (raw)
In-Reply-To: <1456355175-3230-1-git-send-email-ydesmouc@cisco.com>

On Thu, Feb 25, 2016 at 12:06:15AM +0100, Yoann Desmouceaux wrote:
> The enic PMD driver send function uses a constant offset instead
> of relying on the data_off in the mbuf to find the start of the packet.
> 
> Signed-off-by: Yoann Desmouceaux <ydesmouc@cisco.com>
> ---
>  drivers/net/enic/enic_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
> index 07a9810..f818c32 100644
> --- a/drivers/net/enic/enic_main.c
> +++ b/drivers/net/enic/enic_main.c
> @@ -166,7 +166,7 @@ void enic_send_pkt(struct enic *enic, struct vnic_wq *wq,
>  	uint16_t mss = 0;
>  	uint8_t vlan_tag_insert = 0;
>  	uint64_t bus_addr = (dma_addr_t)
> -	    (tx_pkt->buf_physaddr + RTE_PKTMBUF_HEADROOM);
> +	    (tx_pkt->buf_physaddr + tx_pkt->data_off);
>  
>  	if (sop) {
>  		if (ol_flags & PKT_TX_VLAN_PKT)
> -- 
> 2.1.4
> 
Fixes: fefed3d1e62c ("enic: new driver")

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

  reply	other threads:[~2016-03-10 21:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 23:06 Yoann Desmouceaux
2016-03-10 21:32 ` Bruce Richardson [this message]
2016-03-10 21:35   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160310213257.GA19700@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=johndale@cisco.om \
    --cc=ydesmouc@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).