From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6CC9937B6 for ; Thu, 10 Mar 2016 22:36:01 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 10 Mar 2016 13:36:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,317,1455004800"; d="scan'208";a="931264480" Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.20.226]) by orsmga002.jf.intel.com with SMTP; 10 Mar 2016 13:35:58 -0800 Received: by (sSMTP sendmail emulation); Thu, 10 Mar 2016 21:35:57 +0025 Date: Thu, 10 Mar 2016 21:35:57 +0000 From: Bruce Richardson To: Yoann Desmouceaux Message-ID: <20160310213557.GB19700@bricha3-MOBL3> References: <1456355175-3230-1-git-send-email-ydesmouc@cisco.com> <20160310213257.GA19700@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160310213257.GA19700@bricha3-MOBL3> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, johndale@cisco.com Subject: Re: [dpdk-dev] [PATCH] enic: fix dma addr of outgoing packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 21:36:01 -0000 On Thu, Mar 10, 2016 at 09:32:58PM +0000, Bruce Richardson wrote: > On Thu, Feb 25, 2016 at 12:06:15AM +0100, Yoann Desmouceaux wrote: > > The enic PMD driver send function uses a constant offset instead > > of relying on the data_off in the mbuf to find the start of the packet. > > > > Signed-off-by: Yoann Desmouceaux > > --- > > drivers/net/enic/enic_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c > > index 07a9810..f818c32 100644 > > --- a/drivers/net/enic/enic_main.c > > +++ b/drivers/net/enic/enic_main.c > > @@ -166,7 +166,7 @@ void enic_send_pkt(struct enic *enic, struct vnic_wq *wq, > > uint16_t mss = 0; > > uint8_t vlan_tag_insert = 0; > > uint64_t bus_addr = (dma_addr_t) > > - (tx_pkt->buf_physaddr + RTE_PKTMBUF_HEADROOM); > > + (tx_pkt->buf_physaddr + tx_pkt->data_off); > > > > if (sop) { > > if (ol_flags & PKT_TX_VLAN_PKT) > > -- > > 2.1.4 > > > Fixes: fefed3d1e62c ("enic: new driver") > > Acked-by: Bruce Richardson > Applied to dpdk-next-net/rel_16_04 /Bruce