From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] vhost: Fix default value of kickfd and callfd
Date: Fri, 11 Mar 2016 15:19:07 +0800 [thread overview]
Message-ID: <20160311071907.GI979@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1457593565-16240-1-git-send-email-mukawa@igel.co.jp>
On Thu, Mar 10, 2016 at 04:06:05PM +0900, Tetsuya Mukawa wrote:
> Currently, default values of kickfd and callfd are -1.
> If the values are -1, current code guesses kickfd and callfd haven't
> been initialized yet. And vhost library will guess the virtqueue isn't
> ready for processing.
> But callfd and kickfd will be set as -1 when "--enable-kvm"
> isn't specified in QEMU command line. It means we cannot treat -1 as
> uninitialized state. The patch changes default values to -2. And the
> patch defines -2 as VIRTIO_UNINITIALIZED_EVENTFD.
This looks more like a workaround to me. Besides, this patch would make
following fail:
eventfd_write(vq->callfd, (eventfd_t)1);
--yliu
next prev parent reply other threads:[~2016-03-11 7:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 6:14 [dpdk-dev] [PATCH] " Tetsuya Mukawa
2016-03-10 6:25 ` Tan, Jianfeng
2016-03-10 6:34 ` Tetsuya Mukawa
2016-03-10 6:39 ` Tan, Jianfeng
2016-03-10 6:42 ` Tetsuya Mukawa
2016-03-10 7:06 ` [dpdk-dev] [PATCH v2] " Tetsuya Mukawa
2016-03-11 7:19 ` Yuanhan Liu [this message]
2016-03-14 1:54 ` Tetsuya Mukawa
2016-03-14 2:08 ` Yuanhan Liu
2016-03-14 7:54 ` Tetsuya Mukawa
2016-03-14 8:21 ` Yuanhan Liu
2016-03-14 8:31 ` Tetsuya Mukawa
2016-03-14 8:53 ` [dpdk-dev] [PATCH v3] " Tetsuya Mukawa
2016-03-14 9:12 ` Yuanhan Liu
2016-03-14 23:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311071907.GI979@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=mukawa@igel.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).