From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 233852B96 for ; Fri, 11 Mar 2016 16:24:46 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 11 Mar 2016 07:24:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,321,1455004800"; d="scan'208";a="931812906" Received: from cberenge-mobl.ger.corp.intel.com ([10.252.22.153]) by orsmga002.jf.intel.com with SMTP; 11 Mar 2016 07:24:44 -0800 Received: by (sSMTP sendmail emulation); Fri, 11 Mar 2016 15:24:43 +0025 Date: Fri, 11 Mar 2016 15:24:43 +0000 From: Bruce Richardson To: Adrien Mazarguil Message-ID: <20160311152443.GA12500@bricha3-MOBL3> References: <1456165148-28416-1-git-send-email-adrien.mazarguil@6wind.com> <1457015279-3089-1-git-send-email-adrien.mazarguil@6wind.com> <1457015279-3089-6-git-send-email-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457015279-3089-6-git-send-email-adrien.mazarguil@6wind.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 5/5] mlx5: add VLAN insertion offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 15:24:47 -0000 On Thu, Mar 03, 2016 at 03:27:59PM +0100, Adrien Mazarguil wrote: > From: Yaacov Hazan > > VLAN insertion is done in software by the PMD by default unless > CONFIG_RTE_LIBRTE_MLX5_VERBS_VLAN_INSERTION is enabled and Verbs provides > support for hardware insertion. > > When enabled, this option improves performance when VLAN insertion is > requested, however ConnectX-4 Lx boards cannot take advantage of > multi-packet send optimizations anymore. > > Signed-off-by: Yaacov Hazan > Signed-off-by: Adrien Mazarguil > --- > config/common_linuxapp | 1 + > doc/guides/nics/mlx5.rst | 9 +++ > doc/guides/rel_notes/release_16_04.rst | 6 ++ > drivers/net/mlx5/Makefile | 9 +++ > drivers/net/mlx5/mlx5_defs.h | 9 +++ > drivers/net/mlx5/mlx5_ethdev.c | 12 ++-- > drivers/net/mlx5/mlx5_rxtx.c | 109 +++++++++++++++++++++++++++------ > drivers/net/mlx5/mlx5_rxtx.h | 13 ++++ > drivers/net/mlx5/mlx5_txq.c | 15 ++++- > 9 files changed, 158 insertions(+), 25 deletions(-) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index 7b5e49f..793d262 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -220,6 +220,7 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n > CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N=4 > CONFIG_RTE_LIBRTE_MLX5_MAX_INLINE=0 > CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8 > +CONFIG_RTE_LIBRTE_MLX5_VERBS_VLAN_INSERTION=n > New build time configuration options are no longer allowed in DPDK, as they can't be used in binary distributions and make testing harder. This should be made a run-time option instead. /Bruce