* [dpdk-dev] [PATCH] nfp: fix how tx checksum is advertised to firmware
@ 2016-03-03 11:26 Alejandro Lucero
2016-03-11 15:50 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: Alejandro Lucero @ 2016-03-03 11:26 UTC (permalink / raw)
To: dev
Even with tx checksum offload available, do not set the flag by default.
Fixes: b812daadad0d (\"nfp: add Rx and Tx\")
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 0e3705e..6078e9f 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -1543,7 +1543,8 @@ nfp_net_tx_cksum(struct nfp_net_txq *txq, struct nfp_net_tx_desc *txd,
break;
}
- txd->flags |= PCIE_DESC_TX_CSUM;
+ if (ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK))
+ txd->flags |= PCIE_DESC_TX_CSUM;
}
/* nfp_net_rx_cksum - set mbuf checksum flags based on RX descriptor flags */
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] nfp: fix how tx checksum is advertised to firmware
2016-03-03 11:26 [dpdk-dev] [PATCH] nfp: fix how tx checksum is advertised to firmware Alejandro Lucero
@ 2016-03-11 15:50 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2016-03-11 15:50 UTC (permalink / raw)
To: Alejandro Lucero; +Cc: dev
On Thu, Mar 03, 2016 at 11:26:07AM +0000, Alejandro Lucero wrote:
> Even with tx checksum offload available, do not set the flag by default.
>
> Fixes: b812daadad0d (\"nfp: add Rx and Tx\")
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---
Applied to dpdk-next-net/rel_16_04
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-11 15:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-03 11:26 [dpdk-dev] [PATCH] nfp: fix how tx checksum is advertised to firmware Alejandro Lucero
2016-03-11 15:50 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).