From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Tomasz Kulasek <tomaszx.kulasek@intel.com>, <dev@dpdk.org>,
Jan Viktorin <viktorin@rehivetech.com>, <jianbo.liu@linaro.org>
Subject: Re: [dpdk-dev] [PATCH v5] examples/l3fwd: em path performance fix
Date: Fri, 18 Mar 2016 16:22:00 +0530 [thread overview]
Message-ID: <20160318105158.GA13693@localhost.localdomain> (raw)
In-Reply-To: <1902439.xcempkFplY@xps13>
On Fri, Mar 18, 2016 at 11:04:49AM +0100, Thomas Monjalon wrote:
> 2016-03-18 10:52, Tomasz Kulasek:
> > +#if !defined(NO_HASH_MULTI_LOOKUP) && defined(__ARM_NEON)
>
> I think we should use CONFIG_RTE_ARCH_ARM_NEON here.
> Any ARM maintainer to confirm?
__ARM_NEON should work existing GCC, but it is better to use
RTE_MACHINE_CPUFLAG_NEON as
-it has been generated by probing the compiler capabilities.
-it's future-proof solution to support clang or other gcc versions in
future
➜ [master]laptop [dpdk-master] $ aarch64-thunderx-linux-gnu-gcc -dM -E - < /dev/null | grep NEON
#define __ARM_NEON_FP 12
#define __ARM_NEON 1
make output
aarch64-thunderx-linux-gnu-gcc -Wp,-MD,./.eal.o.d.tmp -pthread
-march=armv8-a+crc -mcpu=thunderx -DRTE_MACHINE_CPUFLAG_NEON
-DRTE_MACHINE_CPUFLAG_CRC32
-DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_NEON,RTE_CPUFLAG_CRC32
-I/export/dpdk-master/build/include -include
/export/dpdk-master/build/include/rte_config.h
-I/export/dpdk-master/lib/librte_eal/linuxapp/eal/include
-I/export/dpdk-master/lib/librte_eal/common
-I/export/dpdk-master/lib/librte_eal/common/include
-I/export/dpdk-master/lib/librte_ring
-I/export/dpdk-master/lib/librte_mempool
-I/export/dpdk-master/lib/librte_ivshmem -W -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations -Wold-style-definition
-Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual
-Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -Werror
-O3 -D_GNU_SOURCE -o eal.o -c
/export/dpdk-master/lib/librte_eal/linuxapp/eal/eal.c
Jerin
>
> Note that there is already another occurence of this compiler flag:
> examples/l3fwd/l3fwd_em.c:#elif defined(__ARM_NEON)
next prev parent reply other threads:[~2016-03-18 10:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 17:23 [dpdk-dev] [PATCH] " Tomasz Kulasek
2016-03-07 6:19 ` Xu, Qian Q
2016-03-08 12:58 ` [dpdk-dev] [PATCH v2] " Tomasz Kulasek
2016-03-11 11:14 ` Thomas Monjalon
2016-03-11 12:28 ` Kulasek, TomaszX
2016-03-11 12:10 ` [dpdk-dev] [PATCH v3] " Tomasz Kulasek
2016-03-11 16:23 ` Thomas Monjalon
2016-03-11 17:48 ` Kulasek, TomaszX
2016-03-15 14:31 ` Kulasek, TomaszX
2016-03-15 14:49 ` Thomas Monjalon
2016-03-15 16:06 ` Kulasek, TomaszX
2016-03-15 19:42 ` [dpdk-dev] Odp.: " Czekaj, Maciej
2016-03-18 9:36 ` [dpdk-dev] [PATCH v4] " Tomasz Kulasek
2016-03-18 9:43 ` Kulasek, TomaszX
2016-03-18 9:52 ` [dpdk-dev] [PATCH v5] " Tomasz Kulasek
2016-03-18 10:04 ` Thomas Monjalon
2016-03-18 10:52 ` Jerin Jacob [this message]
2016-03-18 11:00 ` Thomas Monjalon
2016-03-18 11:16 ` [dpdk-dev] [PATCH] examples/l3fwd: prefer probed NEON flag to ARM gcc flag Thomas Monjalon
2016-03-18 11:20 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2016-03-18 11:56 ` [dpdk-dev] [PATCH v5] examples/l3fwd: em path performance fix Jan Viktorin
2016-03-18 12:45 ` Kulasek, TomaszX
2016-03-18 12:50 ` Jan Viktorin
2016-03-18 13:31 ` [dpdk-dev] [PATCH v6] " Tomasz Kulasek
2016-03-21 11:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318105158.GA13693@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=jianbo.liu@linaro.org \
--cc=thomas.monjalon@6wind.com \
--cc=tomaszx.kulasek@intel.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).