From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9924837A6 for ; Fri, 18 Mar 2016 17:21:52 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 18 Mar 2016 09:21:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,355,1455004800"; d="scan'208";a="766890977" Received: from akolekta-mobl1.ger.corp.intel.com ([10.252.6.121]) by orsmga003.jf.intel.com with SMTP; 18 Mar 2016 09:21:25 -0700 Received: by (sSMTP sendmail emulation); Fri, 18 Mar 2016 16:21:24 +0025 Date: Fri, 18 Mar 2016 16:21:24 +0000 From: Bruce Richardson To: Jianfeng Tan Cc: dev@dpdk.org, helin.zhang@intel.com, konstantin.ananyev@intel.com, adrien.mazarguil@6wind.com Message-ID: <20160318162123.GA13720@bricha3-MOBL3> References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com> <1457941376-15852-1-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457941376-15852-1-git-send-email-jianfeng.tan@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v8 00/11] Add API to get supported packet types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 16:21:53 -0000 On Mon, Mar 14, 2016 at 03:42:45PM +0800, Jianfeng Tan wrote: > To achieve this, a new function pointer, dev_supported_ptypes_get, is added > into struct eth_dev_ops. For those devices who do not implement it, it > means it does not support any ptypes. > > v8: > - Rebased on dpdk-next-net/rel_16_04 branch. > - Rename ptypes_info -> supported_ptypes. > - Abandon info about newly added API in release_16_04.rst. > - concise -> correct. > > v7: > - 2.2 -> 16.04 > - Add note: this API better invoked after device is already started. > - Update release_16_04.rst for newly added API. > > v6: > - Remove extern in function declaration. > - Update rte_ether_version.map. > > v5: > - Exclude l3fwd change from this series, as a separated one. > - Fix malposition of mlx4 code in mlx5 commit introduced in v4. > > v4: > - Change how to use this API: to previously agreement reached in mail. > > v3: > - Change how to use this API: api to allocate mem for storing ptype > array; and caller to free the mem. > - Change how to return back ptypes from PMDs: return a pointer to > corresponding static const array of supported ptypes, terminated > by RTE_PTYPE_UNKNOWN. > - Fix l3fwd parse_packet_type() when EXACT_MATCH is enabled. > - Fix l3fwd memory leak when calling the API. > > v2: > - Move ptype_mask filter function from each PMDs into ether layer. > - Add ixgbe vPMD's ptype info. > - Fix code style issues. > > Signed-off-by: Jianfeng Tan > Acked-by: Konstantin Ananyev > Acked-by: Adrien Mazarguil > Applied to dpdk-next-net/rel_16_04, using v9 of patch 1 and v8 of all others. /Bruce