From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0061.outbound.protection.outlook.com [157.56.111.61]) by dpdk.org (Postfix) with ESMTP id A7DF22E8F for ; Sun, 20 Mar 2016 18:28:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-caviumnetworks-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=R5E/LStcVCXuCAt9Dh8D1EAU5gF2ejrGveVZSaLh+Yk=; b=1+Z72/T/6Bt/fr1eLOnSwhIbdpczOXaeA6ZGy/3LmNVzzDvLnvXYvhtcPFUg+OIRqq67KLKygmzeeYEJ3PIOHCZsXckueNWrAORj1laJuTtV+KKvrGCg9CX9zLBBBeJZKyykBdr8h+p4JmGWrCkbKH8NA5g8rLYth1U0Fdd4HP0= Authentication-Results: rehivetech.com; dkim=none (message not signed) header.d=none;rehivetech.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (122.171.52.131) by BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) with Microsoft SMTP Server (TLS) id 15.1.434.16; Sun, 20 Mar 2016 17:28:01 +0000 Date: Sun, 20 Mar 2016 22:57:37 +0530 From: Jerin Jacob To: Jan Viktorin CC: , , , Message-ID: <20160320172736.GA16373@localhost.localdomain> References: <1458379590-18618-1-git-send-email-viktorin@rehivetech.com> <1458417485-29436-3-git-send-email-viktorin@rehivetech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1458417485-29436-3-git-send-email-viktorin@rehivetech.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.171.52.131] X-ClientProxiedBy: BM1PR01CA0012.INDPRD01.PROD.OUTLOOK.COM (25.163.198.147) To BLUPR0701MB1713.namprd07.prod.outlook.com (25.163.85.14) X-MS-Office365-Filtering-Correlation-Id: cd8266c9-9646-4b96-4cfa-08d350e4fe11 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 2:Tl2Qrqih2LJZH9+6N3o/kRJfcbULKo+AW59O9bF0kWYx1ZKsYUDvUvLHsEwEDoGOzUJ6Js4BmW4sAv64anrR/vsSv+eJSqtJlJFFQcvcSYb5mtGhlaSu5klAyGNdyxofq1B86hW7e3vr3RO58OIPFncJ8oLIw6Nol1SOwSlV6zEYXJCLT+sGLxMXaQxrQSd3; 3:ypGrzCykLSwCRXD9wFuAvDZA6M1hj4HApvXXDK65bux2FiIvoIGem9D9c2EzYsloeZ5Plin4tryurUArraCDhBfQg/mtk2vhP3DmAmSrAGcYO8MZlEwLNpOmgtcLG0Os; 25:N2kd7JbE/wBQ1+WyyqntAVEQDwwJcqQ/G/cfw3LEuGUpC14ClqccUroCe3ENpqtX3Odp/EZBT6dQz1ZoUUuaFQj1HMFM2soSMySd6xoA9qI7ECZh3NR4Wd5hOgpMqKZPZ7u1pKtGJG2IYHuRyRTIk+og+jFcnFzRMqZn5Y5csAl8zpg+zqQvfgjlhnoaDkDdRSbQ9GTu1U+BmOfYNVYSiGu0dwk7p95NMZf/xVfLzi9dANAsZqGR5zXqI7B4pXadPR4A5FvzApJ1wJv7cshykRpr5FVkfAJKfzt9noS040R//MSlLLm0gXw+8zKpVr+/WjSHOKJ8uti3yQ0U38wsRwa8boHNEewc4mGW1KzleYNwOGn+VSdDx5XeZVJ84y818g1hq7HZ+0j8t443vQpdFSUXIDiAsoNnZR69SxSXgw7TnS8L34nctKsvRFaQ+wbavAcPd0qkiRqpV2E9FtnVUC+M0UDDWMpHWE8Syrdwbg1w9YCa6CkURBVXyTbH7Mo080ZHPdYw99YowgXfV1fjOIFl2Igwr0XZfNmwd+r0CTCQyAP2SMBqxNIEKyMTCsQw X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 20:CtPt0Se0i4fcTCUFcSZkaaLq7n+/24D4gEb5b081aUbbaNlai7JOo6B69q6Fig9BJ3fOD/QdlRd0j1Rr4xTHGh7ln19kpXVZP7C0CIC6AC5c2LDgEiEHt6dvlFam++KyhSE5ktCWFjbo0WD45OdYQLuM1DrSU8kytGH3jR9gndS+ArJckXOfDUvu5XzV0meLfj9xOd7AGhbN59kc6wpCLaz5DGc702DJN5yCxZwZBPKUT8e60mbCKZsWLGSbKxsRfPWmhv11Su1biZ1ccl1jCjSkHhHajj8Ha3cjWnqsplUIpYNXJ51i+ih33r/kDSVOiBnd0NzQ8DBRHXLQ8umyzwpNV0voZ5hdvUGpvEtetbym2rh5nVaUS3hd7+uMg9x5x2cszIUD/8hhLapPP0sU0JLkqaqciLUBdJVsTurR6s0bxWqHFv0RzkH2tEJwkWZ+HTcT7rVq4ycSltuCUoTh3h9yyyvVE3/H8kh9erX75hW4aseScDzcoSmIfrGtDzJP95Oy59Hbznepplnn6f+aARqU5BpXnJqhUipAp4u6t5FTHjao1Si/09MQIuDPxJY0/Mje647r+bc6f481Nrf2mS8lEH+AaRIVYUPwptHJFZo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:BLUPR0701MB1713; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 4:6dRBjYzxp6cEQzQD2CjeWaUp4EHQ3Btx7jWECCQYtAQQZ9j6EhTSEXCCMIzYxglC3WSzthFWqbgHn6tFwxgcgCpHYgkWTj8fPsawfa+zSJcbTqF88awnLs3lYlhMOqXq36914ddxeZugQA34AR4cwQ9IHM7jMd2TqXmAKh1VBB2d54fm90isYwAWAaOg7gIy/ipEON4kf6+GXAIduN88jrfKe8bQ6zggQtRGVlyxur9FVAw7xmsYHE4foi1l1clN80fyhXQ2gywIC1gZNOtKJa5P5UtsVi/6OD8uKCNplgHZB/AOjedUhA9k3XtLqvrnRkTDnbZk5d69pB9tHoyad049zXN3xrr/RvEf6qGb9ZYdR+GzVnurAyTfJVT1rlbm X-Forefront-PRVS: 088751B4D4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(24454002)(1096002)(50466002)(47776003)(33656002)(4326007)(586003)(1076002)(6116002)(189998001)(66066001)(77096005)(110136002)(3846002)(2906002)(86362001)(2950100001)(23726003)(61506002)(76176999)(5008740100001)(4001350100001)(5004730100002)(19580395003)(19580405001)(92566002)(42186005)(81166005)(97756001)(50986999)(46406003)(54356999); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1713; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 23:gjrMA8PKP7j5sZgSkqMbQtAs8/LItVLfuXyTSGGFoIgvPYTcoT3cvQvhB3kR8D5tYG0SVlBO/CZz1GDSRa3oVIIwv3sUYXMwRmSXlPvMEBVZlAS297iPW15Vm38x0yxWs1xtkr6c4X9GYi3ibTTEFMOzb2pF+AoZoQcpFr5OXsG0s7ROJVo8h4dqLdBo6VwTbTPFUB3YkYkzpzleyLJaLfeAH+hqrHFrcinAEiw3xiuObEXC91Tz0d6l7PwdDxUj+7qQ8hjnOZbC2ZuPMvpWf81VOxbmJYwJKnBHwvxuVusHmIROEIuxWyLba97zSrq/UJ463bwXZWE0nsC7XJ8/Jr0rkspuy57sOOnWvZPXyR6tyCSx3tKiEu8JAyLKo2VZrAEKaWbF8tze3Op4vB4flcziGnMtcZEMlhRHxFY/H/OpPTDKBWxXFnLovGjuJhNwlkngt/iMCQS60/X0Sk7B3uhz7yDv4Pt2dkYr2MwDkMdeHx+0MoltMjZo6mvs008PvVlH4UOJD+ykS4z/aV/3fGEejyur6efXv0HsKVAXrQfRhxcAG6WwIl4KRuH2BfCDrVcmtfLzQcPN3aO++S1ZAG0FvtwreYbuikUAh9K6l5HRHs3G8spoK19THsbbOr2FSd7F4+pCUbhWdNmk+cvUosvt+ZtK5RR/8r0nsSinnyDvHqQ74lqfGPb25Ha4kforhfUe3M29ihi4LOILkeXUuUxp0Yjs6CLwhSASfdqUwAEANmqVpAGHLelbbrN46I3vLUEg4SHgA6co72GuvsV6owztmvyPk6HgCYGOK44kTOf0Mm58gN4aTye1ZgxsSK3ns/ykN3FNDpPL3+3g/9pM9fWYXmtSOBmrXL2OIRxbJ3bqHGtpGYJOcXufrOAkjO0QmjFK72kVpP5Wfg0qcierQJjMfPmgGCaOyfFsH74kJdPlEk4Jt2IpMI4Aw7IP2YT/ X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 5:GtSQDIfjvIp7mOl2DRkbkt+7XrsGQFQBVJON+BpDcHK1QMZ9YRNBApy2lGlkuT6aD6g776GrnDlLsy/otZfRSH0JFt8Zz7aEcRzthRH75n0rUzEZKQr9/lcJDtGtOgMgt9gSOEvVVe5IhwYWaQROrQ==; 24:HzENzQQ2bR5d7kgD4mv2/NOYx1qRMJy9KHtMNBd13UKeD4II3P/UZfclWl5nBS/sPzCJ/G9r0MFsusKUnhL9lfhNZWsneE+ljgisXuSEhIM= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2016 17:28:01.1246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1713 Subject: Re: [dpdk-dev] [PATCH v3 2/4] arm: detect NEON cpu feature by checking __ARM_NEON X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Mar 2016 17:28:06 -0000 On Sat, Mar 19, 2016 at 08:58:03PM +0100, Jan Viktorin wrote: > The __ARM_NEON declares that the arm_neon.h is available which is not true for > the __ARM_NEON_FP. The __ARM_NEON_FP is not provided by aarch64 gcc. It depends on specific aarch64 compiler builds. Some aarch64 gcc versions do provide __ARM_NEON_FP. [~] $ aarch64-thunderx-linux-gnu-gcc -dM -E - < /dev/null |grep "NEON\|FP" #define __ARM_FP 12 #define __ARM_NEON_FP 12 #define __FP_FAST_FMAF 1 #define __ARM_NEON 1 #define __FP_FAST_FMA 1 However, This patch is correct, we should use __ARM_NEON. For this series, Acked-by: Jerin Jacob > > $ arm-linux-gnueabi-gcc -dM -E - < /dev/null | grep "_FP\|_NEON" > #define __ARM_FP 12 > #define __ARM_NEON_FP 4 > #define __VFP_FP__ 1 > > $ arm-linux-gnueabi-gcc -mfpu=neon -dM -E - < /dev/null | grep "_FP\|_NEON" > #define __ARM_FP 12 > #define __ARM_NEON_FP 4 > #define __ARM_NEON__ 1 > #define __VFP_FP__ 1 > #define __ARM_NEON 1 > > $ aarch64-linux-gnu-gcc -dM -E - < /dev/null | grep "NEON\|FP" > #define __FP_FAST_FMAF 1 > #define __ARM_NEON 1 > #define __FP_FAST_FMA 1 > > Signed-off-by: Jan Viktorin > --- > mk/rte.cpuflags.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk > index 19a3e7e..529bcef 100644 > --- a/mk/rte.cpuflags.mk > +++ b/mk/rte.cpuflags.mk > @@ -111,7 +111,7 @@ CPUFLAGS += VSX > endif > > # ARM flags > -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON_FP),) > +ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),) > CPUFLAGS += NEON > endif > > -- > 2.7.0 >