From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0063.outbound.protection.outlook.com [207.46.100.63]) by dpdk.org (Postfix) with ESMTP id 30D80532D for ; Sun, 20 Mar 2016 18:38:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-caviumnetworks-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qMt0abx5Z7AFmSIBgx6ED67VbLUWDKrdcOzWJkQtpAY=; b=PdXqas6RcdN9JMRiSd2fGhT0lNzrNmS0k4VyWNpYSCH10NO4GFU3BEx05kqepA5UlUnEmL/9NoKRWvOMp7vz+Slq+v19v+0t2XnCOiVKu2kulg1PvYglKXds9Cgj9umQ7Envpk/PJMgJB57GCEkG11UI1xm8o8Hl+Zv9A502nqc= Authentication-Results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (122.171.52.131) by BN3PR0701MB1719.namprd07.prod.outlook.com (10.163.39.18) with Microsoft SMTP Server (TLS) id 15.1.434.16; Sun, 20 Mar 2016 17:38:45 +0000 Date: Sun, 20 Mar 2016 23:08:17 +0530 From: Jerin Jacob To: Thomas Monjalon CC: Jan Viktorin , , , Message-ID: <20160320173816.GB16373@localhost.localdomain> References: <1458417485-29436-1-git-send-email-viktorin@rehivetech.com> <1752293.0PmA76bAcf@xps13> <20160320104110.3c05f405@jvn> <10088842.WxuXTY5r1p@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <10088842.WxuXTY5r1p@xps13> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.171.52.131] X-ClientProxiedBy: MAXPR01CA0008.INDPRD01.PROD.OUTLOOK.COM (25.164.147.15) To BN3PR0701MB1719.namprd07.prod.outlook.com (25.163.39.18) X-MS-Office365-Filtering-Correlation-Id: b7cfdb1a-1c20-4fb1-1f86-08d350e67e30 X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 2:jMhsphY4ed+RYPDRPTNDbD0pVIKuVoY/3AEQWKx11pWhA52LYxYmdvue6/mOGy53rAG47sFhKflkwozxOvw2SV7Puo93dEEBWnLlcCsQNeLluRi9OdpEDiZJ04UhxaBHd7Z2SaoX3LYCVyL+VN7BSwjNJn92OY9daOobnujKEvIkQePVnQI8SXboul9Kgu6V; 3:n+182Bq7Qk/mGNE0114z1bYpGS96daXrIbrkcqTtfG/RB9uz+WSA0THOpwfB0TraDVJT2PfkijJYAwFpD1qubo3+BzbMjv8XsI1nfQW2LSQfUwgb71X+RjzSsGCZOOct; 25:xVkB8OmJoF+OsILYdiP6Yx6Gioe09Yfk2h1VbaGafVXeUmKptBIrzJw4VrWjnmXmNsVceLbj4Y79OmxXyMp/VZItHG+oSETmpienClV15i2X5n5HSyeJ9oYNTBd0i4JFrdjWO3sbAeuQIid4p/R3UTpCW+HDbSIl8YWdBx8/fOUoL4UvKhhby6a76f6R4zGpDFGOz4MgBvg2FLXHPb/ip4+EAgndzk4WYNKZ1dVa2F4nht+9i+/eH99KhdI9v+gO9sHOTAW5TcX6aJIx1qDLNwqBFeyHZ7mgjQFxeVUPDxI+8naDK/6meIniLSa8wViG5acuM3WBooOD38Z1JaomHjBZl0ok3bmZ9D8FCHWGec/zBAE1FgjUrvocPJpLgA+KgR3tCIDkk5JE3GQiXIjNg0tAMVFpTucnCUoJLys+zdXvk0xlIbC5emtSUarboBCdtf1y7EMDC+E+PTKQ9whilV6QxImDDtEm9Rtnpr/FehV4mSPh/68AgqnjegOm1pAxVRGpPWLA5Nq8bd3zxVrPAQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1719; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 20:KwrRXFa2vnzz/qFUWXMwTycUCxNz/c22qdWhlWfkRkAvIZ8xTHfuxg2AV0zk3sSSlz1/E9CQ5dtNtprHzHcUmmM8F2XflawbV5PF8zfseyQkQIFF9BE6bvk3/H9D2DFc0BhbjeIQxznNe08rrCpYqeIbSWXlb9ykVDu88wBJ0C7qCUsx5qhI9VdardU7dybtZ9shI6zfG+cVzmrlcXn3cuCc54fmwKnyYvJCoapNiMujhEuTwdz7nqLifjxCXRT5xbSaySBuh+g04JdgfJt9yXMyZjLao0TGrsfCrauC7Jux5rVlSSYK5lc5XsCeHOR4kEG5GSX7x8vZpjLzV2DS9YRsSXtPsmxLKYCbSixGEdMJN8c6U9KK8u231tgldL06W03ZcD3SI/HYn/nY8ot38a8GI2Gck05/u6WXjP8z98tl5wcYLyk8F3j2lY3+rfqA9KRnJ+erAJk/DtDX15VnsZard8tpJZuehhMBXRmX0AIeZRmo+Su4EXNlScvu7BTZlS8sz9cfLc680348K8EhGH57Hc2apppddVg74kDNUG4FjL5DqsP0mr2q/rs/Yx4H4j9oOkcyNafYaUH0Vsxdry1jix8sbsYqDKT2KguwufA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:BN3PR0701MB1719; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1719; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 4:apGrcI5+f6/dRUCmymOys2QB3gWjoVIu30QdKZqdXmZWldRFRpVoDCPDjerM5upvKJxigY3kbdtZwn52mQV/EoVfBFeJxNds/AAdlBXOozGMa9SdI5uzfGWa+53+5rdQ94q8BIwJu8Ut7peXTb/y+U9JH//Ma5VDjqxy9bdDnALUQQ1NQPlNPMnlJD9ExYMFnkg/g2lLYaGuo6VWhyN06E+7ONkCORT00WjuKdEF6thnb1EM3YZ/KwT9Tn2tOl7KIQGz+Ft6DkVK2ufhs/8bFxJUFjy7H3orv12xWrCHXGia4RRJtvZxrl1tOAnae/dh1fiYabN7XzflSLZOK9BHWq7ZLWW+ATm1xwHICT4AfbdsZJnVNLLh7UvNSpNfH8GC X-Forefront-PRVS: 088751B4D4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(377424004)(24454002)(4001350100001)(33656002)(5004730100002)(97756001)(50466002)(47776003)(66066001)(77096005)(2950100001)(46406003)(86362001)(5008740100001)(93886004)(2906002)(1096002)(1076002)(19580405001)(4326007)(42186005)(81166005)(110136002)(3846002)(92566002)(23726003)(54356999)(50986999)(189998001)(19580395003)(6116002)(76176999)(61506002)(586003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1719; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1719; 23:WSwp0nUIRpf9oJuProvRaKFQ/Fhz2bgCd8TuILI?= =?us-ascii?Q?F/dqdiqm1XthxYTOBWvlNuwR0dpLhDt3ZMDyhDz0rhmp/HFpJ6CA66IzgGNZ?= =?us-ascii?Q?/GvbZu2XficJmD/cpJ8/ylhssRWeIVQbspj41fOhRnTtFsZQzVDHfy37h2on?= =?us-ascii?Q?PFkULlyOTjCzrvZbi0/CDbjDy3f/ZYJBggb4784QVom4HFC9MxhyEeNljhGs?= =?us-ascii?Q?WN51yaMQEDcCQ40PrhmyAtOTyIS+OVFPsL4NsvRnZYSxsgEz91QeWLoqAhuR?= =?us-ascii?Q?0E/eNLVYdFM1hjua0A+jTsOD2UM01acByBIw7RmZodtpQZOYZh1oXM5u+RM2?= =?us-ascii?Q?ktbuDHRKi+nrhOZpkvQmCWD2QtLET0FrxmyWyoyeB8kU+ZvPiMr8feUFnN0b?= =?us-ascii?Q?oswU88uqW/TfVqiWrouzSSeZwd8Uc2IIfv0R2sCglcbD12Tu3zp/mxUXJxkg?= =?us-ascii?Q?kPyiK2ySI7qO2h//6xG1LFhd+2SBg8sxPt7baAhRbqxHmZ72PnuUlAU4/1dM?= =?us-ascii?Q?Fsg3wH2uZQY4sJ7x7VOESJc9yumRn1YqWFNfiaOtMZZ69ftho7bELcf0Eide?= =?us-ascii?Q?v416ouHqi/XlJ737clui8x4b51/n8EU6jkGjTfu7K7Z4fqGuctJVzhNTY8H5?= =?us-ascii?Q?cHQ7o5B9v7QNUlvPNlqaqJHOqHPBx0TNzgvxp9B9XlPuNQ6Wcn/qJT+uqyRQ?= =?us-ascii?Q?8uelc+XsuZ7IUsf8g6D0d5ehOthoBCV3kfyDP82ZWjOuCkjltVHKQ36ZYZWI?= =?us-ascii?Q?AVhuW4dcKBF7pE3YM+D4Ezf21UeUDYXQZ+Oqzfyfl7PSdl3jP5qHnFM2WZsG?= =?us-ascii?Q?xPTl8Dg+c2fsLneqOarINJXM/ysbxQdIBuXA1wJur9VRf5GLmeERTq9U+Utp?= =?us-ascii?Q?IYwSLoQThbpFXR7uyyMUoWBcoGWXBOYEG70he9h3eOzj4C156KorhNzXvuYD?= =?us-ascii?Q?o5sns1eo/qd6eePsY2POWc7KjB3NnPofbmSYO/Koewra65rYZ5vd53Wg6RA+?= =?us-ascii?Q?boZY=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 5:d0jo2zwfcGZQgllgPitS0ZfCKPRI6r5xznjSIaOA1Kl5n7I+n5ZMsfEbVwjWKE5vcSoMaBFMtenxV7pV0Ri3uXKc/LXS3vFNYxWKcTCCWTF6V7DM3U90xWpeU39VRu5MnDRJmuwrPuPnaEJiXzlZtQ==; 24:G1WSGPyRqDqGvx7xiRPlttBGPikQQJ+uhacV0q5VJmtv2Mcrc8z0ROz/ZFBA+VyuucRo6I6itu6AcOLtgTCxP8MTdeyAlDYygnfywm8mja4= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2016 17:38:45.8529 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1719 Subject: Re: [dpdk-dev] [PATCH v3 4/4] eal/arm: introduce CONFIG_RTE_ARCH_ARM_NEON_MEMCPY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Mar 2016 17:38:50 -0000 On Sun, Mar 20, 2016 at 11:29:48AM +0100, Thomas Monjalon wrote: > 2016-03-20 10:41, Jan Viktorin: > > On Sat, 19 Mar 2016 21:14:57 +0100 > > Thomas Monjalon wrote: > > > > > 2016-03-19 20:58, Jan Viktorin: > > > > The flag is used to enable memcpy optimizations in EAL. As it is not always > > > > the performance benefit, the flag allows to disable it. > > > > > > Ideally the default should be to choose the best optimization. > > > If it is not possible, it would help to have some comments explaining > > > how to choose wether enabling NEON memcpy or not. > > > > Ok, we can rename the option to CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY, > > delete it from the defconfig and change the test in rte_memcpy_32.h to > > > > #ifndef CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY > > > > Alternatively, to have a positive test like > > > > #ifdef CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY > > > > I can create a bigger change that moves the non-neon-memcpy up in the > > file... > > > > Should I resend the whole series as v3? > > No, I don't think changing the name of the config or moving code > will change anything. > We just need to understand when it must be enabled or disabled. By default, NEON implementation should be enabled in default config file, if a given arm target/cpu has issue with NEON specific implementation at target/cpu config level it can be disabled. IMO, Its inline with Jan's Patch. The factors like NEON instruction execution cycles and pipelines supported etc highly depend on the ARM target vendor implementation. (ie arm specification does not mandate those fine-grained details) so let target/cpu configuration decides any expectation is required or not. Jerin