From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id A287E2906
 for <dev@dpdk.org>; Mon, 21 Mar 2016 12:05:42 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga103.fm.intel.com with ESMTP; 21 Mar 2016 04:05:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,371,1455004800"; d="scan'208";a="70322115"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.10])
 by fmsmga004.fm.intel.com with SMTP; 21 Mar 2016 04:05:17 -0700
Received: by  (sSMTP sendmail emulation); Mon, 21 Mar 2016 11:05:14 +0025
Date: Mon, 21 Mar 2016 11:05:14 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Zhuangyanying <ann.zhuangyanying@huawei.com>
Message-ID: <20160321110514.GA11312@bricha3-MOBL3>
References: <1458539108-15686-1-git-send-email-mukawa@igel.co.jp>
 <1458539108-15686-2-git-send-email-mukawa@igel.co.jp>
 <1523315.o3rXJh0SOG@xps13>
 <CAKU8wkeFnPzFQSi8aAGzdHJHx6M0X8B7HJPx4+Hn7bbUitfu8w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKU8wkeFnPzFQSi8aAGzdHJHx6M0X8B7HJPx4+Hn7bbUitfu8w@mail.gmail.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v13 1/2] ethdev: Add a new event type to
 notify a queue state changed event
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Mar 2016 11:05:43 -0000

On Mon, Mar 21, 2016 at 06:24:36PM +0900, Tetsuya Mukawa wrote:
> 2016-03-21 17:37 GMT+09:00 Thomas Monjalon <thomas.monjalon@6wind.com>:
> > 2016-03-21 14:45, Tetsuya Mukawa:
> >> This event will be occured when some queues are enabled or disabled.
> >> So far, only vhost PMD supports the event, and it indicates some queues
> >> are enabled or disabled by virtio-net device. Such an event is needed
> >> because virtio-net device may not enable all queues vhost PMD prepare.
> >>
> >> Because only vhost PMD uses the event so far, it isn't an actual hardware
> >> interrupt but a simple software event.
> > [...]
> >>
> >> +     RTE_ETH_EVENT_QUEUE_STATE_CHANGE,
> >> +                             /**< queue state changed interrupt */
> >
> > Is the shorter RTE_ETH_EVENT_QUEUE_STATE descriptive enough?
> >
> > What about this comment?
> > /**< queue state event (enabled/disabled) */
> 
> Hi Thomas,
> 
> Yes, it's enough, and above comment is nice.
> Thanks for suggestion.
> 
> 
> Hi Bruce,
> 
> If today is the deadline, could you kindly please replace above
> changes while merging?
> I need half a day to re-submit the patch. Sorry for asking it.
> I will ask my company to let me have vpn access. ;)
> 
> Regards,
> Tetsuya

Yes, I can fix on apply to dpdk-next-net.

/Bruce