From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.228.170]) by dpdk.org (Postfix) with ESMTP id AB9592BFD for ; Tue, 22 Mar 2016 08:39:21 +0100 (CET) Received: by mail.mhcomputing.net (Postfix, from userid 1000) id 2B419261; Tue, 22 Mar 2016 00:39:21 -0700 (PDT) Date: Tue, 22 Mar 2016 00:39:21 -0700 From: Matthew Hall To: "Liang, Cunming" Cc: thomas.monjalon@6wind.com, dev@dpdk.org Message-ID: <20160322073921.GA28285@mhcomputing.net> References: <1455399524-3252-1-git-send-email-mhall@mhcomputing.net> <20160317225531.GA10279@mhcomputing.net> <56EFA9B4.9080404@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56EFA9B4.9080404@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [dpdk-dev, 1/3] rte_interrupts: add rte_eal_intr_exit to shut down IRQ thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 07:39:21 -0000 On Mon, Mar 21, 2016 at 03:58:44PM +0800, Liang, Cunming wrote: > the default termination handler I am not so experienced with this "default termination handler". Can someone clarify what it is so I could comment better about it? > If EINTR is caused by some non-term purpose signals, are you going > to exit the interrupt thread any way? We should discuss what makes sense here. I'm just trying to get some things working and finding EINTR was getting eaten and causing infinite looping. > Without setting 'PTHREAD_CREATE_DETACHED' won't cause the infinite > loop. However by using pthread_cancel to terminate the thread, > indeed it's necessary to set 'PTHREAD_CREATE_DETACHED'. My general understanding is that PTHREAD_CREATE_DETACHED should be used for any thread, which should not keep a process open by itself if it is executing, i.e. a "daemon thread". I believe the interrupt thread qualifies as such a thread if I have understood everything right (which is hard to promise when you only work in DPDK in spare time). > It looks like 'pthread_cancel' is the right way and I saw it > continue keeps current EINTR handling in EAL interrupt thread. It is one option. Depending what makes the most sense. > 1. Can you explain and add patch comments why default signal handler > is not good enough to terminate app. Yes if someone call tell me more about what it is so I can check it. > 2. I propose to add addition comments on rte_epoll_wait() API > description. For any signal, it causes an error return, user needs > to handle. Agreed. > 3. Will you do a favorite to add 'PTHREAD_CREATE_DETACHED' to all > EAL pthread too. As a spare time developer I am a bit conservative about too large of a scope and messing with code for other threads or features I didn't personally use or test. This is because I don't have the same QA resources as Intel / 6WIND / etc.. Some help from a full time developer would be great here. > Cunming Matthew.