From: Bruce Richardson <bruce.richardson@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com,
harish.patil@qlogic.com, sony.chacko@qlogic.com
Subject: Re: [dpdk-dev] [PATCH v3 05/10] qede: Add core driver
Date: Tue, 22 Mar 2016 10:55:54 +0000 [thread overview]
Message-ID: <20160322105554.GA19248@bricha3-MOBL3> (raw)
In-Reply-To: <1458348805-32648-6-git-send-email-rasesh.mody@qlogic.com>
On Fri, Mar 18, 2016 at 05:53:20PM -0700, Rasesh Mody wrote:
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
> ---
> drivers/net/qede/Makefile | 90 +++
> drivers/net/qede/qede_eth_if.h | 176 +++++
> drivers/net/qede/qede_ethdev.c | 957 +++++++++++++++++++++++
> drivers/net/qede/qede_ethdev.h | 156 ++++
> drivers/net/qede/qede_if.h | 155 ++++
> drivers/net/qede/qede_logs.h | 93 +++
> drivers/net/qede/qede_main.c | 548 ++++++++++++++
> drivers/net/qede/qede_rxtx.c | 1172 +++++++++++++++++++++++++++++
> drivers/net/qede/qede_rxtx.h | 187 +++++
> drivers/net/qede/rte_pmd_qede_version.map | 4 +
> 10 files changed, 3538 insertions(+)
> create mode 100644 drivers/net/qede/Makefile
> create mode 100644 drivers/net/qede/qede_eth_if.h
> create mode 100644 drivers/net/qede/qede_ethdev.c
> create mode 100644 drivers/net/qede/qede_ethdev.h
> create mode 100644 drivers/net/qede/qede_if.h
> create mode 100644 drivers/net/qede/qede_logs.h
> create mode 100644 drivers/net/qede/qede_main.c
> create mode 100644 drivers/net/qede/qede_rxtx.c
> create mode 100644 drivers/net/qede/qede_rxtx.h
> create mode 100644 drivers/net/qede/rte_pmd_qede_version.map
>
Checkpatch is reporting a lot of issues with this patch. Can you please look to
reduce the number of hits in it. Perhaps you could use the "checkpatches.sh"
script in the dpdk repo to check all patches in this set.
Regards,
/Bruce
next prev parent reply other threads:[~2016-03-22 10:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 0:53 [dpdk-dev] [PATCH v3 00/10] qede: Add qede PMD Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 01/10] qede: Add maintainers Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 02/10] qede: Add documentation Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 03/10] qede: Add license file Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 04/10] qede: Add base driver Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 05/10] qede: Add core driver Rasesh Mody
2016-03-21 17:32 ` Stephen Hemminger
2016-03-22 1:14 ` Rasesh Mody
2016-03-22 10:55 ` Bruce Richardson [this message]
2016-03-22 11:03 ` Bruce Richardson
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 06/10] qede: Add L2 support Rasesh Mody
2016-03-22 11:04 ` Bruce Richardson
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 07/10] qede: Add SRIOV support Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 08/10] qede: Add attention support Rasesh Mody
2016-03-22 11:07 ` Bruce Richardson
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 09/10] qede: Add DCBX support Rasesh Mody
2016-03-19 0:53 ` [dpdk-dev] [PATCH v3 10/10] qede: Enable PMD build Rasesh Mody
2016-03-22 11:21 ` Bruce Richardson
2016-03-22 11:21 ` [dpdk-dev] [PATCH v3 00/10] qede: Add qede PMD Richardson, Bruce
2016-03-22 11:30 ` Bruce Richardson
2016-03-29 20:52 ` Rasesh Mody
2016-03-30 12:34 ` Bruce Richardson
2016-03-24 1:52 ` Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322105554.GA19248@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=ameen.rahman@qlogic.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).