From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id A94C41396
 for <dev@dpdk.org>; Tue, 22 Mar 2016 12:04:17 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga101.jf.intel.com with ESMTP; 22 Mar 2016 04:03:47 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,376,1455004800"; d="scan'208";a="71018695"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.103])
 by fmsmga004.fm.intel.com with SMTP; 22 Mar 2016 04:03:45 -0700
Received: by  (sSMTP sendmail emulation); Tue, 22 Mar 2016 11:03:43 +0025
Date: Tue, 22 Mar 2016 11:03:43 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com,
 harish.patil@qlogic.com, sony.chacko@qlogic.com
Message-ID: <20160322110343.GB19248@bricha3-MOBL3>
References: <1458348805-32648-1-git-send-email-rasesh.mody@qlogic.com>
 <1458348805-32648-6-git-send-email-rasesh.mody@qlogic.com>
 <20160322105554.GA19248@bricha3-MOBL3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160322105554.GA19248@bricha3-MOBL3>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v3 05/10] qede: Add core driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Mar 2016 11:04:18 -0000

On Tue, Mar 22, 2016 at 10:55:54AM +0000, Bruce Richardson wrote:
> On Fri, Mar 18, 2016 at 05:53:20PM -0700, Rasesh Mody wrote:
> > Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> > Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> > Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
> > ---
> >  drivers/net/qede/Makefile                 |   90 +++
> >  drivers/net/qede/qede_eth_if.h            |  176 +++++
> >  drivers/net/qede/qede_ethdev.c            |  957 +++++++++++++++++++++++
> >  drivers/net/qede/qede_ethdev.h            |  156 ++++
> >  drivers/net/qede/qede_if.h                |  155 ++++
> >  drivers/net/qede/qede_logs.h              |   93 +++
> >  drivers/net/qede/qede_main.c              |  548 ++++++++++++++
> >  drivers/net/qede/qede_rxtx.c              | 1172 +++++++++++++++++++++++++++++
> >  drivers/net/qede/qede_rxtx.h              |  187 +++++
> >  drivers/net/qede/rte_pmd_qede_version.map |    4 +
> >  10 files changed, 3538 insertions(+)
> >  create mode 100644 drivers/net/qede/Makefile
> >  create mode 100644 drivers/net/qede/qede_eth_if.h
> >  create mode 100644 drivers/net/qede/qede_ethdev.c
> >  create mode 100644 drivers/net/qede/qede_ethdev.h
> >  create mode 100644 drivers/net/qede/qede_if.h
> >  create mode 100644 drivers/net/qede/qede_logs.h
> >  create mode 100644 drivers/net/qede/qede_main.c
> >  create mode 100644 drivers/net/qede/qede_rxtx.c
> >  create mode 100644 drivers/net/qede/qede_rxtx.h
> >  create mode 100644 drivers/net/qede/rte_pmd_qede_version.map
> > 
> Checkpatch is reporting a lot of issues with this patch. Can you please look to
> reduce the number of hits in it. Perhaps you could use the "checkpatches.sh"
> script in the dpdk repo to check all patches in this set.
> 
> Regards,
> /Bruce

Also, can the commit be given a fuller description in the commit message
describing what is included in this patch, and also what is omitted from it i.e.
what's going to be added in later patches.

/Bruce