From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 089072BA9 for ; Tue, 22 Mar 2016 19:28:00 +0100 (CET) Received: by mail-pf0-f175.google.com with SMTP id u190so322873942pfb.3 for ; Tue, 22 Mar 2016 11:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AdNsHsrTvszF/cNrD6/t3YQ7BbqEbT1mIpsjfJwnmlw=; b=gLjdORNolRVRxGYkHyy5uC2HRClJ1y8Y+TvLtPJ1PNAmrlbhE95fUKB1o6JCXwIWuR Yx3fcedM00MhgAdpYrhQLTdglcZTboQH313Gz1delURln68myWY6aGbXG2WxKe+wh1yR licY4n1pBaKcIrLbOLmSsuSM8XLhwnLKhFkSCBeP0MQisj8KgTlHd9+oISdAs/4fLyNd ecIU1b6dIg9/z9OIZavD8FES44nKTiusMFlkybvWzmFE2MLceRTLGORKlyo0CKEVVWR+ l1+bAZWUrbFgZ/PRP3IrI3Tb/UimhwBFeiPF79A1kCsjWHYzsXu48ChYAf3NE2MF1CV4 qPhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AdNsHsrTvszF/cNrD6/t3YQ7BbqEbT1mIpsjfJwnmlw=; b=deTdjOuj+MYbXvnxTsE1MZh0mzZinrb6QCCSfsQJz8/oOcu4u1Hz6DtrMgyCHZAg2t tgdrzcW4jyURyDg7nyOyLtj/hP4Bh34wkIc+xESmSfYhY7tif6cI2/5/0WBTB+fpjIRZ XWp/oAXo+KzuoNbrAAsB3k57gS8TqfaAP699PNjUP5/ZUp1hn5cZraUVBlJID1rNFxGa SmJ0QmawGARAig6kky0rXVq8BEO4mkrIMLGRetC8P4aFhpFdaXsno5o5DvYvDcfTDTP7 D1yZWLzxl+zsx01DGiPteUsUc+QnpBfY7w21Rq8+rQ3gqk/LSxAfWp52przi9q4cbXNC gzVg== X-Gm-Message-State: AD7BkJLHS5A2tZihlEVMAEpaygGMgQxXWLZbwcWnd+PEjLF6LK0K11jEbW7l+jMKwzIhEw== X-Received: by 10.98.19.2 with SMTP id b2mr54360905pfj.93.1458671279394; Tue, 22 Mar 2016 11:27:59 -0700 (PDT) Received: from xeon-e3 (static-50-53-65-230.bvtn.or.frontiernet.net. [50.53.65.230]) by smtp.gmail.com with ESMTPSA id f66sm49955290pff.8.2016.03.22.11.27.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Mar 2016 11:27:59 -0700 (PDT) Date: Tue, 22 Mar 2016 11:28:15 -0700 From: Stephen Hemminger To: "Tahhan, Maryam" Cc: Thomas Monjalon , Igor Ryzhov , "dev@dpdk.org" , "olivier.matz@6wind.com" Message-ID: <20160322112815.71b3d064@xeon-e3> In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536B10163B@IRSMSX106.ger.corp.intel.com> References: <1457615010-87436-1-git-send-email-iryzhov@nfware.com> <2180400.M1OUCR6DC3@xps13> <1A27633A6DA49C4A92FCD5D4312DBF536B10163B@IRSMSX106.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 18:28:00 -0000 On Tue, 22 Mar 2016 15:23:22 +0000 "Tahhan, Maryam" wrote: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Thursday, March 17, 2016 4:41 PM > > To: Igor Ryzhov > > Cc: dev@dpdk.org; Tahhan, Maryam ; > > olivier.matz@6wind.com > > Subject: Re: [dpdk-dev] [PATCH] ethdev: don't count missed packets in > > erroneous packets counter > > > > CC Maryam and Olivier who had discussions about imissed and other > > stats: > > http://dpdk.org/ml/archives/dev/2015-August/022905.html > > http://dpdk.org/ml/archives/dev/2015-September/023351.html > > http://dpdk.org/ml/archives/dev/2015-September/023612.html > > > > 2016-03-10 16:03, Igor Ryzhov: > > > Comment for "ierrors" counter says that it counts erroneous received > > packets. But for some reason "imissed" counter is added to "ierrors" > > counter in most drivers. It is a mistake, because missed packets are > > obviously not received. This patch fixes it. > > > > According to this patch > > http://dpdk.org/browse/dpdk/commit/?id=70bdb186 > > imissed was kept in ierrors because of backward compatibility. > > I'm OK to remove imissed from ierrors. > > > > Fixes: 70bdb18657da ("ethdev: add Rx error counters for missed, badcrc > > and badlen packets") > > Fixes: 6bfe648406b5 ("i40e: add Rx error statistics") > > Fixes: 856505d303f4 ("cxgbe: add port statistics") > > > > Acked-by: Thomas Monjalon > > Looks fine, but make sure to add an explicit comment in release notes somewhere to flag the change. In case any apps were accounting for imissed as part of ierrors like testpmd was: > > - if (((stats->ierrors - stats->imissed) + stats->rx_nombuf) > 0) { > + if ((stats->ierrors + stats->rx_nombuf) > 0) { Extra () in that expression.