From: Bruce Richardson <bruce.richardson@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] bnx2x: Tx performance improvement fixes
Date: Tue, 22 Mar 2016 14:29:58 +0000 [thread overview]
Message-ID: <20160322142958.GA21000@bricha3-MOBL3> (raw)
In-Reply-To: <1457660877-2570-2-git-send-email-rasesh.mody@qlogic.com>
On Thu, Mar 10, 2016 at 05:47:56PM -0800, Rasesh Mody wrote:
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> ---
> drivers/net/bnx2x/bnx2x.c | 207 +++++++++++++++++---------------------
> drivers/net/bnx2x/bnx2x.h | 4 +-
> drivers/net/bnx2x/bnx2x_ethdev.c | 53 ++++++++++
> drivers/net/bnx2x/bnx2x_rxtx.c | 47 +++++----
> 4 files changed, 173 insertions(+), 138 deletions(-)
>
This patch needs a commit message with a description of changes and how they
help with performance.
If there are multiple changes being made to improve the performance, or add in
extra TX features, they would be better split into separate patches, with one
unique change per patch. If any of the changes are bug-fixes as opposed to
performance improvements (since the word "fixes" appears in the title here), they
should each be in a separate patch, with a message describing the fix and
including a "fixes" line in the message as described here:
http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body
Thanks,
/Bruce
next prev parent reply other threads:[~2016-03-22 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 1:47 [dpdk-dev] [PATCH 1/3] bnx2x: Update documentation Rasesh Mody
2016-03-11 1:47 ` [dpdk-dev] [PATCH 2/3] bnx2x: Tx performance improvement fixes Rasesh Mody
2016-03-22 14:29 ` Bruce Richardson [this message]
2016-04-01 0:23 ` Rasesh Mody
2016-03-11 1:47 ` [dpdk-dev] [PATCH 3/3] bnx2x: Update PMD version to 1.1.0 Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322142958.GA21000@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=rasesh.mody@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).