From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C86EA28BF for ; Tue, 22 Mar 2016 15:30:05 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 22 Mar 2016 07:30:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,377,1455004800"; d="scan'208";a="916447165" Received: from fooyekan-mobl2.ger.corp.intel.com ([10.252.25.15]) by orsmga001.jf.intel.com with SMTP; 22 Mar 2016 07:29:59 -0700 Received: by (sSMTP sendmail emulation); Tue, 22 Mar 2016 14:29:58 +0025 Date: Tue, 22 Mar 2016 14:29:58 +0000 From: Bruce Richardson To: Rasesh Mody Cc: dev@dpdk.org Message-ID: <20160322142958.GA21000@bricha3-MOBL3> References: <1457660877-2570-1-git-send-email-rasesh.mody@qlogic.com> <1457660877-2570-2-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457660877-2570-2-git-send-email-rasesh.mody@qlogic.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 2/3] bnx2x: Tx performance improvement fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 14:30:06 -0000 On Thu, Mar 10, 2016 at 05:47:56PM -0800, Rasesh Mody wrote: > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > --- > drivers/net/bnx2x/bnx2x.c | 207 +++++++++++++++++--------------------- > drivers/net/bnx2x/bnx2x.h | 4 +- > drivers/net/bnx2x/bnx2x_ethdev.c | 53 ++++++++++ > drivers/net/bnx2x/bnx2x_rxtx.c | 47 +++++---- > 4 files changed, 173 insertions(+), 138 deletions(-) > This patch needs a commit message with a description of changes and how they help with performance. If there are multiple changes being made to improve the performance, or add in extra TX features, they would be better split into separate patches, with one unique change per patch. If any of the changes are bug-fixes as opposed to performance improvements (since the word "fixes" appears in the title here), they should each be in a separate patch, with a message describing the fix and including a "fixes" line in the message as described here: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body Thanks, /Bruce