From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4807A29C6 for ; Tue, 22 Mar 2016 18:19:16 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 22 Mar 2016 10:19:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,378,1455004800"; d="scan'208";a="71248006" Received: from fooyekan-mobl2.ger.corp.intel.com ([10.252.25.15]) by fmsmga004.fm.intel.com with SMTP; 22 Mar 2016 10:19:13 -0700 Received: by (sSMTP sendmail emulation); Tue, 22 Mar 2016 17:19:12 +0025 Date: Tue, 22 Mar 2016 17:19:12 +0000 From: Bruce Richardson To: "Lu, Wenzhuo" Cc: "Wang, Xiao W" , "Zhang, Helin" , "dev@dpdk.org" Message-ID: <20160322171911.GH20448@bricha3-MOBL3> References: <1458268055-22668-1-git-send-email-xiao.w.wang@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090343C682@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090343C682@shsmsx102.ccr.corp.intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix reta query and update on x550 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 17:19:16 -0000 On Fri, Mar 18, 2016 at 03:19:35AM +0000, Lu, Wenzhuo wrote: > Hi, > > > > -----Original Message----- > > From: Wang, Xiao W > > Sent: Friday, March 18, 2016 10:28 AM > > To: Zhang, Helin > > Cc: dev@dpdk.org; Lu, Wenzhuo; Wang, Xiao W > > Subject: [PATCH] ixgbe: fix reta query and update on x550 > > > > For x550 device, the reta table has 512 entries, but in function > > ixgbe_dev_rss_reta_query and ixgbe_dev_rss_reta_update we use an "uint8_t i" > > to traverse the entries, this will lead the function to an endless loop. > > > > This patch changes the data type from uint8_t to uint16_t to fix the issue. > > > > Fixes: 4bee94a6c22f ("ixgbe: support 512 RSS entries on x550") > > > > Signed-off-by: Wang Xiao W > Acked-by: Wenzhuo Lu > Applied to dpdk-next-net/rel_16_04 /Bruce