From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Qian Xu <qian.q.xu@intel.com>,
Masaru OKI <m-oki@stratosphere.co.jp>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix vmware e1000 input/output error
Date: Tue, 22 Mar 2016 19:05:54 -0700 [thread overview]
Message-ID: <20160322190554.4aca11d2@xeon-e3> (raw)
In-Reply-To: <2437286.FLD0q4sve1@xps13>
On Mon, 21 Mar 2016 11:07:56 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2016-03-21 17:01, Qian Xu:
> > INTX is badly emulated in Vmware, INTX toggle check didn't work
> > with Vmware e1000 device. The patch is to fix the issue.
>
> Is it possible to detect a VMware e1000 device?
>
> > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> > case RTE_INTR_MODE_LEGACY:
> > - if (pci_intx_mask_supported(dev)) {
> > - dev_dbg(&dev->dev, "using INTX");
> > - udev->info.irq_flags = IRQF_SHARED;
> > - udev->info.irq = dev->irq;
> > - udev->mode = RTE_INTR_MODE_LEGACY;
> > - break;
> > - }
> > - dev_notice(&dev->dev, "PCI INTX mask not supported\n");
> > + dev_dbg(&dev->dev, "using INTX");
> > + udev->info.irq_flags = IRQF_SHARED;
> > + udev->info.irq = dev->irq;
> > + udev->mode = RTE_INTR_MODE_LEGACY;
> > + break;
> > /* fall back to no IRQ */
> > case RTE_INTR_MODE_NONE:
>
> This patch is removing the INTX support detection and the
> fallback to no IRQ.
>
I agree with Thomas. If the kernel's "does INTx work" test fails then
most likely VMware is broken and later attempts to mask the interrupt
won't work. Better to have the DPDK abstraction layer
handle this. The EAL should:
1) log a message when detected
2) report that link state (and data) interrupts are not supported
by setting proper flags so application knows that LSC is not available.
3) give an error return on all attempts to enable interrupts.
prev parent reply other threads:[~2016-03-23 2:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 9:01 Qian Xu
2016-03-21 10:07 ` Thomas Monjalon
2016-03-23 1:23 ` Xu, Qian Q
2016-03-23 2:05 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322190554.4aca11d2@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=m-oki@stratosphere.co.jp \
--cc=qian.q.xu@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).