[dpdk-dev] [PATCH] mlx5: fix packet padding macro check

[dpdk-dev] [PATCH] mlx5: fix packet padding macro check

[Adrien Mazarguil]

All instances of HAVE_EXP_CREATE_WQ_FLAG_RX_END_PADDING were not replaced by
HAVE_VERBS_RX_END_PADDING during a rework of the original patch, effectively
preventing this feature from being used.

Fixes: 89ed2405447d ("mlx5: add support for HW packet padding")

Unfortunately I did not catch this earlier (one should avoid last minute
changes).

Bruce, since the above commit is currently only present in your tree, can
you merge this fix with it during your next rebase? I do not mind keeping
a separate fix but the commit ID will have to be updated later. Thanks.

Adrien Mazarguil (1):
  mlx5: fix packet padding macro check

 drivers/net/mlx5/mlx5.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.1.4

[dpdk-dev] [PATCH] mlx5: fix packet padding macro check

[Adrien Mazarguil]

All instances of HAVE_EXP_CREATE_WQ_FLAG_RX_END_PADDING were not replaced by
HAVE_VERBS_RX_END_PADDING during a rework of the original patch, effectively
preventing this feature from being used.

Fixes: 89ed2405447d ("mlx5: add support for HW packet padding")

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 drivers/net/mlx5/mlx5.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 7ac495a..041cfc3 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -359,9 +359,9 @@ mlx5_pci_devinit(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
 #ifdef HAVE_EXP_DEVICE_ATTR_VLAN_OFFLOADS
 			IBV_EXP_DEVICE_ATTR_VLAN_OFFLOADS |
 #endif /* HAVE_EXP_DEVICE_ATTR_VLAN_OFFLOADS */
-#ifdef HAVE_EXP_CREATE_WQ_FLAG_RX_END_PADDING
+#ifdef HAVE_VERBS_RX_END_PADDING
 			IBV_EXP_DEVICE_ATTR_RX_PAD_END_ALIGN |
-#endif /* HAVE_EXP_CREATE_WQ_FLAG_RX_END_PADDING */
+#endif /* HAVE_VERBS_RX_END_PADDING */
 			0;
 #endif /* HAVE_EXP_QUERY_DEVICE */
 
-- 
2.1.4

Re: [dpdk-dev] [PATCH] mlx5: fix packet padding macro check

[Bruce Richardson]

On Wed, Mar 23, 2016 at 10:25:49AM +0100, Adrien Mazarguil wrote:
> All instances of HAVE_EXP_CREATE_WQ_FLAG_RX_END_PADDING were not replaced by
> HAVE_VERBS_RX_END_PADDING during a rework of the original patch, effectively
> preventing this feature from being used.
> 
> Fixes: 89ed2405447d ("mlx5: add support for HW packet padding")
> 
> Unfortunately I did not catch this earlier (one should avoid last minute
> changes).
> 
> Bruce, since the above commit is currently only present in your tree, can
> you merge this fix with it during your next rebase? I do not mind keeping
> a separate fix but the commit ID will have to be updated later. Thanks.
> 
Done.

Please check resultant commit on next-net tree:

http://dpdk.org/browse/next/dpdk-next-net/commit/?h=rel_16_04&id=62d20c4d1a463379c63584bee3f102699b59c036

thanks,
/Bruce

Re: [dpdk-dev] [PATCH] mlx5: fix packet padding macro check

[Adrien Mazarguil]

On Wed, Mar 23, 2016 at 11:53:22AM +0000, Bruce Richardson wrote:
> On Wed, Mar 23, 2016 at 10:25:49AM +0100, Adrien Mazarguil wrote:
> > All instances of HAVE_EXP_CREATE_WQ_FLAG_RX_END_PADDING were not replaced by
> > HAVE_VERBS_RX_END_PADDING during a rework of the original patch, effectively
> > preventing this feature from being used.
> > 
> > Fixes: 89ed2405447d ("mlx5: add support for HW packet padding")
> > 
> > Unfortunately I did not catch this earlier (one should avoid last minute
> > changes).
> > 
> > Bruce, since the above commit is currently only present in your tree, can
> > you merge this fix with it during your next rebase? I do not mind keeping
> > a separate fix but the commit ID will have to be updated later. Thanks.
> > 
> Done.
> 
> Please check resultant commit on next-net tree:
> 
> http://dpdk.org/browse/next/dpdk-next-net/commit/?h=rel_16_04&id=62d20c4d1a463379c63584bee3f102699b59c036

Perfect, thanks!

-- 
Adrien Mazarguil
6WIND