From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 47AFE2B95
 for <dev@dpdk.org>; Wed, 23 Mar 2016 18:50:10 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP; 23 Mar 2016 10:45:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,383,1455004800"; d="scan'208";a="674530855"
Received: from dkoncewi-mobl3.ger.corp.intel.com ([10.252.21.244])
 by FMSMGA003.fm.intel.com with SMTP; 23 Mar 2016 10:45:24 -0700
Received: by  (sSMTP sendmail emulation); Wed, 23 Mar 2016 17:45:22 +0025
Date: Wed, 23 Mar 2016 17:45:22 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>
Cc: Tetsuya Mukawa <mukawa@igel.co.jp>, "dev@dpdk.org" <dev@dpdk.org>,
 "ann.zhuangyanying@huawei.com" <ann.zhuangyanying@huawei.com>,
 "yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>
Message-ID: <20160323174522.GB11680@bricha3-MOBL3>
References: <1458634185-2526-1-git-send-email-mukawa@igel.co.jp>
 <74F120C019F4A64C9B78E802F6AD4CC24F847A6D@IRSMSX106.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <74F120C019F4A64C9B78E802F6AD4CC24F847A6D@IRSMSX106.ger.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] vhost PMD: Fix wrong handling of maximum
 value of rx/tx queues
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Mar 2016 17:50:11 -0000

On Tue, Mar 22, 2016 at 05:17:42PM +0000, Loftus, Ciara wrote:
> > 
> > Currently, the maximum value of rx/tx queueus are kept by EAL. But,
> > the value are used like below different meanings in vhost PMD.
> >  - The maximum value of current enabled queues.
> >  - The maximum value of current supported queues.
> > 
> > This wrong double meaning will cause an issue like below steps.
> > 
> > * Invoke application with below option.
> >   --vdev 'eth_vhost0,iface=<socket path>,queues=4'
> > * Configure queues like below.
> >   rte_eth_dev_configure(portid, 2, 2, ...);
> > * Configure queues again like below.
> >   rte_eth_dev_configure(portid, 4, 4, ...);
> > 
> > The second rte_eth_dev_configure() will be failed because both
> > the maximum value of current enabled queues and supported queues
> > will be '2' after calling first rte_eth_dev_configure().
> > 
> > To fix the issue, the patch prepare one more variable to keep the
> > number of maximum supported queues in vhost PMD.
> > 
> > Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> > ---
<snip> 
> Acked-by: Ciara Loftus <ciara.loftus@intel.com>
> 
Applied to dpdk-next-net/rel_16_04

/Bruce