From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id D93F82BA0
 for <dev@dpdk.org>; Thu, 24 Mar 2016 13:04:25 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP; 24 Mar 2016 05:04:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,385,1455004800"; d="scan'208";a="770582692"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.85])
 by orsmga003.jf.intel.com with SMTP; 24 Mar 2016 05:04:23 -0700
Received: by  (sSMTP sendmail emulation); Thu, 24 Mar 2016 12:04:20 +0025
Date: Thu, 24 Mar 2016 12:04:19 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Michael Habibi <mikehabibi@gmail.com>
Cc: dev@dpdk.org
Message-ID: <20160324120419.GA13728@bricha3-MOBL3>
References: <CAOsp8o-F-QAqmEV=9GkeB4DZz+YhHwNY=GYW1C9q8EdoVQ9R1g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOsp8o-F-QAqmEV=9GkeB4DZz+YhHwNY=GYW1C9q8EdoVQ9R1g@mail.gmail.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] Bug in i40e PMD for flexible payload
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Mar 2016 12:04:26 -0000

On Wed, Mar 23, 2016 at 01:44:46PM -0500, Michael Habibi wrote:
> We are using the i40 implementation to configure flow director with
> flexible payload rules. When setting up rules, it allows you to set a value
> to 63 to disable the rule (NONUSE_FLX_PIT_DEST_OFF). However, the macro in
> question is always adding an offset value 50
> (I40E_FLX_OFFSET_IN_FIELD_VECTOR). This doesn't work when you use it in
> conjunction with NONUSE_FLX_PIT_DEST_OFF to disable it, because instead of
> taking 63 as is, it does 63 + 50 and breaks the functionality.
> 
> We used the following fix and it appears to work. Just sharing with the
> DPDK team in case they want to bring it in.
>
Thanks for this. Can you perhaps resubmit this fix in the form of an official
patch to DPDK, including a proper sign-off on it. The details for contributing
patches to DPDK is documented here: 
http://dpdk.org/doc/guides/contributing/patches.html

Without a signoff, we can't take in your code and use it.

Regards,
/Bruce