Re: [dpdk-dev] [PATCH v4 0/3] Fix incorrect max TX queue numbers for ixgbe

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Mar 24, 2016 at 05:44:58PM +0000, Bruce Richardson wrote:
> On Thu, Mar 24, 2016 at 03:22:01PM +0000, Pablo de Lara wrote:
> > IXGBE supports 128 TX queues. However, the full 128 queues
> > are only available in VT and DCB mode.
> > In normal default "none" mode (VT/DCB off) the maximum number
> > of available queues is only 64.
> > IXGBE doesn't check the mode when reporting the available
> > number of queues. If a queue larger than 64 is used in default mode,
> > the TX packets will be dropped silently.
> > 
> > This patchset:
> > 
> > - Modifies the device info to show the correct maximum number of available TX queues,
> >   depending on the mode.
> > 
> > - Adds a check to forbid using a queue number larger than 64
> >   during device configuration (in default mode), so that the problem is
> >   reported as early as possible.
> > 
> > - It also changes the order of where the dev_conf parameters are copied
> >   into the dev structure so that the correct maximum number of queues
> >   is reported for the correct mode.
> > 
> > Changes in v4:
> > - Split the patch in three smaller patches
> > - Updated release notes document
> > 
> > Changes in v3:
> > - Fixed wrong set of TX queues for 82596EB
> > 
> > Changes in v2:
> > 
> > - Reorder memcpy of device configuration in rte_eth_dev_configure(),
> >   so function gets the correct maximum number of queues
> >   (depending on the operation mode), before checking the
> >   requested number of queues.
> > - Renamed new macro
> > - Reworded/wrapped commit message
> > 
> > Pablo de Lara (1):
> >   ethdev: copy device configuration earlier
> > 
> > Wenzhuo Lu (2):
> >   ixgbe: fix incorrect tx queue number assignment
> >   ixgbe: fix incorrect max tx queue number
> > 
> All three patches are fixes, so all three should have "Fixes" lines in them.
> Please remember for next time!
> 
> Thanks,
> /Bruce

Applied to dpdk-next-net/rel_16_04, with added fixes lines in each case.

/Bruce