DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Michael Qiu <michael.qiu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] lib/librte_lpm: Fix anonymous union initialization issue
Date: Fri, 25 Mar 2016 10:02:26 -0700	[thread overview]
Message-ID: <20160325100226.18c2b013@xeon-e3> (raw)
In-Reply-To: <1458890426-20688-2-git-send-email-michael.qiu@intel.com>

Making code run with picky compilers is good, as long as it
doesn't break other (more modern) compilers.

> +					new_tbl8_entry.next_hop=next_hop;

Please run your patches through checkpatch, it will warn about missing whitespace like this.

  reply	other threads:[~2016-03-25 17:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25  7:20 [dpdk-dev] [PATCH 0/2] Compile fixes in SUSE11 SP3 i686 platform Michael Qiu
2016-03-25  7:20 ` [dpdk-dev] [PATCH 1/2] lib/librte_lpm: Fix anonymous union initialization issue Michael Qiu
2016-03-25 17:02   ` Stephen Hemminger [this message]
2016-03-30  3:38   ` [dpdk-dev] [PATCH 1/2 v2] " Michael Qiu
2016-03-25  7:20 ` [dpdk-dev] [PATCH 2/2] drivers/crypto: Fix anonymous union initialization in crypto Michael Qiu
2016-03-25 10:48   ` Trahe, Fiona
2016-03-30 12:49   ` [dpdk-dev] [PATCH v2] drivers/crypto: Fix anonymous union initialization in crypto PMDs Fiona Trahe
2016-03-31 19:32 ` [dpdk-dev] [PATCH 0/2] Compile fixes in SUSE11 SP3 i686 platform Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160325100226.18c2b013@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=michael.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).