From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id EC0835599 for ; Fri, 25 Mar 2016 18:02:12 +0100 (CET) Received: by mail-pa0-f41.google.com with SMTP id tt10so50037323pab.3 for ; Fri, 25 Mar 2016 10:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g88RhMVBdLwD2vEmmJso/FZ43K0zib8RVm+tp6s3mQ8=; b=coNLG9na47vTtrPMasuDPtc4TcY5seXWb2bA4I6TKFNVCU7/JQCbVUs/ZBzznBDEtF jlo95V9b5IW/asSobQjZjUi5hmGTw+DYu8DS8VHCNgXJ3vHMNm0vnErm71JQC/Lc2ffj tV+AOEIJpVYV6n/9ygHt5suXMxqaQJqzCO4IgokcUn0WdSXu3FHV4YVDD1bakAj/cpDa qgV7qGaK/6v++7UJiv0kphspvD2kV/fUYYuOZX389jAr1fiYXdEbHQQq1NFyQsLTWrwI yPFfZYQvTJP0XuhMC+kTeMKiBvOFPGfrWJzVen28g9czV8OpvXMf5J55CeEMLLvsnbvC eddg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g88RhMVBdLwD2vEmmJso/FZ43K0zib8RVm+tp6s3mQ8=; b=GxqfLAuskm5Ab6AeuGsC2X+YC+uixui9UNk+le2PfY84fWoGPPSM0fokG6IcVugYau z6SyXskBGZjR7Tl6ilZVtf/jHspux0gDsl9axyellVWRgDJC0pWbcrsvkHGOMN9HH5Ik 4F//MP+q8N3Nz/EHuUkuXN638VzplRLEEczNfN6BpeAQWRDhN4f4aUk0QfW08q8cU4Ne LWv0rssjNruQS3TL9kFgAylfa5uh0TxRyt4abj/jEtz35tflz24fdaWY7dXSveJngu95 k8VKlcngX44iZyearePvpVNWvCc6JpIJPHsPqpKdvo68PVCwdOrbQoaAqpJw4t6HBga2 ItSQ== X-Gm-Message-State: AD7BkJISI/oNDc+mA2R3pyB0nE+ovsw0V/C9C6kJJ2YZFLhXKOiZfnUFgNLGWhKtnoc7TA== X-Received: by 10.66.132.37 with SMTP id or5mr22595250pab.144.1458925332309; Fri, 25 Mar 2016 10:02:12 -0700 (PDT) Received: from xeon-e3 (static-50-53-65-230.bvtn.or.frontiernet.net. [50.53.65.230]) by smtp.gmail.com with ESMTPSA id e6sm17592996pfj.71.2016.03.25.10.02.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Mar 2016 10:02:11 -0700 (PDT) Date: Fri, 25 Mar 2016 10:02:26 -0700 From: Stephen Hemminger To: Michael Qiu Cc: dev@dpdk.org Message-ID: <20160325100226.18c2b013@xeon-e3> In-Reply-To: <1458890426-20688-2-git-send-email-michael.qiu@intel.com> References: <1458890426-20688-1-git-send-email-michael.qiu@intel.com> <1458890426-20688-2-git-send-email-michael.qiu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] lib/librte_lpm: Fix anonymous union initialization issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2016 17:02:13 -0000 Making code run with picky compilers is good, as long as it doesn't break other (more modern) compilers. > + new_tbl8_entry.next_hop=next_hop; Please run your patches through checkpatch, it will warn about missing whitespace like this.