From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 3C5555320
 for <dev@dpdk.org>; Fri, 25 Mar 2016 11:13:30 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga101.jf.intel.com with ESMTP; 25 Mar 2016 03:13:29 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,390,1455004800"; d="scan'208";a="771259365"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.58])
 by orsmga003.jf.intel.com with SMTP; 25 Mar 2016 03:13:27 -0700
Received: by  (sSMTP sendmail emulation); Fri, 25 Mar 2016 10:13:26 +0025
Date: Fri, 25 Mar 2016 10:13:26 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, helin.zhang@intel.com
Message-ID: <20160325101325.GA2796@bricha3-MOBL3>
References: <1456795416-118189-1-git-send-email-jianfeng.tan@intel.com>
 <1458866867-39582-1-git-send-email-jianfeng.tan@intel.com>
 <1458866867-39582-2-git-send-email-jianfeng.tan@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1458866867-39582-2-git-send-email-jianfeng.tan@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: refine API to query supported
	packet types
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Mar 2016 10:13:30 -0000

On Fri, Mar 25, 2016 at 08:47:45AM +0800, Jianfeng Tan wrote:
> Return 0 instead of -ENOTSUP for those which do not fill any packet types,
> with some note and doc updated.
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Hi Jianfeng,

I think this is a good change to the API, as it should simplify app code - as
any driver which doesn't tell us what ptypes it supports should be counted as
not supporting any. It also eliminates the need for the vdevs to see about
exporting this function to say they don't support any types.

However, two comments:
1. I think the commit message for this change should include information as to
why we want to tweak the API of this new function i.e. put in the above reasons
plus any others.
2. Please separate out the doc change from the API change as they are unrelated.

Regards,
/Bruce