From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Liu, Yong" <yong.liu@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] testpmd: fix build on FreeBSD
Date: Fri, 25 Mar 2016 12:10:40 +0000 [thread overview]
Message-ID: <20160325121040.GB18028@bricha3-MOBL3> (raw)
In-Reply-To: <2055843.IvPtHn5Ksq@xps13>
On Wed, Mar 23, 2016 at 04:17:12PM +0100, Thomas Monjalon wrote:
> 2016-03-23 02:17, Wu, Jingjing:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marvin Liu
> > > Build log:
> > > /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named
> > > 's6_addr32' in 'struct in6_addr'
> > > rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]);
> > >
> > > This is caused by macro "s6_addr32" not defined on FreeBSD and testpmd
> > > swap big endian parameter to host endian. Move the swap action to i40e
> > > ethdev will fix this issue.
> > >
> > > Fixes: 7b1312891b69 ("ethdev: add IP in GRE tunnel")
> > >
> > > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> > Acked-by: Jingjing Wu <jingjing.wu@intel.com>
>
> It looks good but something is missing to decide that it is the right fix:
> the API do not state wether these fields (and others) are big endian or
> something else.
>
> Please Jingjing, fix the ethdev comments for these fields and others
> rte_eth_ipv*_flow in a separate patch.
+1 to the more info because the endianness is confusing here. However, this look
a better fix than the previous one (v1 patch).
Thomas, can this be merged for RC2 to fix the BSD build, which should be a
priority? Even if it's not the full solution, I think we need to at least get
the code building on BSD.
Thanks,
/Bruce
next prev parent reply other threads:[~2016-03-25 12:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 1:44 [dpdk-dev] [PATCH] " Marvin Liu
2016-03-21 8:59 ` Mrzyglod, DanielX T
2016-03-21 9:13 ` Sergio Gonzalez Monroy
2016-03-21 9:40 ` De Lara Guarch, Pablo
2016-03-21 14:57 ` Bruce Richardson
2016-03-22 3:30 ` Liu, Yong
2016-03-22 9:44 ` Sergio Gonzalez Monroy
2016-03-22 6:50 ` [dpdk-dev] [PATCH v2] " Marvin Liu
2016-03-22 9:05 ` Qiu, Michael
2016-03-23 9:20 ` Liu, Yong
2016-03-23 2:17 ` Wu, Jingjing
2016-03-23 15:17 ` Thomas Monjalon
2016-03-25 12:10 ` Bruce Richardson [this message]
2016-03-25 12:15 ` Bruce Richardson
2016-03-25 18:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160325121040.GB18028@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=thomas.monjalon@6wind.com \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).