From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 7EF1F2BA0
 for <dev@dpdk.org>; Fri, 25 Mar 2016 13:10:44 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga102.fm.intel.com with ESMTP; 25 Mar 2016 05:10:43 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,390,1455004800"; d="scan'208";a="675493012"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.58])
 by FMSMGA003.fm.intel.com with SMTP; 25 Mar 2016 05:10:42 -0700
Received: by  (sSMTP sendmail emulation); Fri, 25 Mar 2016 12:10:40 +0025
Date: Fri, 25 Mar 2016 12:10:40 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
 "Liu, Yong" <yong.liu@intel.com>, dev@dpdk.org
Message-ID: <20160325121040.GB18028@bricha3-MOBL3>
References: <1458524684-13539-1-git-send-email-yong.liu@intel.com>
 <1458629413-24771-1-git-send-email-yong.liu@intel.com>
 <9BB6961774997848B5B42BEC655768F8DDB9F2@SHSMSX104.ccr.corp.intel.com>
 <2055843.IvPtHn5Ksq@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2055843.IvPtHn5Ksq@xps13>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2] testpmd: fix build on FreeBSD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Mar 2016 12:10:44 -0000

On Wed, Mar 23, 2016 at 04:17:12PM +0100, Thomas Monjalon wrote:
> 2016-03-23 02:17, Wu, Jingjing:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marvin Liu
> > > Build log:
> > > /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named
> > > 's6_addr32' in 'struct in6_addr'
> > >     rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]);
> > > 
> > > This is caused by macro "s6_addr32" not defined on FreeBSD and testpmd
> > > swap big endian parameter to host endian. Move the swap action to i40e
> > > ethdev will fix this issue.
> > > 
> > > Fixes: 7b1312891b69 ("ethdev: add IP in GRE tunnel")
> > > 
> > > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> > Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> 
> It looks good but something is missing to decide that it is the right fix:
> the API do not state wether these fields (and others) are big endian or
> something else.
> 
> Please Jingjing, fix the ethdev comments for these fields and others
> rte_eth_ipv*_flow in a separate patch.

+1 to the more info because the endianness is confusing here. However, this look
a better fix than the previous one (v1 patch).

Thomas, can this be merged for RC2 to fix the BSD build, which should be a 
priority? Even if it's not the full solution, I think we need to at least get
the code building on BSD.

Thanks,
/Bruce