From: Bruce Richardson <bruce.richardson@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH] nfp: copy pci info from pci to ethdev
Date: Fri, 25 Mar 2016 12:31:17 +0000 [thread overview]
Message-ID: <20160325123117.GD18028@bricha3-MOBL3> (raw)
In-Reply-To: <1458748296-15017-1-git-send-email-stephen@networkplumber.org>
On Wed, Mar 23, 2016 at 08:51:36AM -0700, Stephen Hemminger wrote:
> The NFP driver (unlike other PCI devices) was not copying the pci info
> from the pci_dev to the eth_dev. This would make the driver_name be
> null (and other unset fields) when application uses dev_info_get.
>
> This was found by code review; do not have the hardware.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Alejandro,
any review or ack on this patch for nfp driver?
Regards,
/Bruce
next prev parent reply other threads:[~2016-03-25 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 15:51 Stephen Hemminger
2016-03-25 12:31 ` Bruce Richardson [this message]
2016-03-29 7:16 ` Alejandro Lucero
2016-03-31 13:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160325123117.GD18028@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).