From: Bruce Richardson <bruce.richardson@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: disable icc compile warning
Date: Fri, 25 Mar 2016 13:57:30 +0000 [thread overview]
Message-ID: <20160325135729.GA14060@bricha3-MOBL3> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B20DA4@irsmsx105.ger.corp.intel.com>
On Thu, Mar 24, 2016 at 05:47:21PM +0000, Ananyev, Konstantin wrote:
> > -----Original Message-----
> > From: Yigit, Ferruh
> > Sent: Thursday, March 24, 2016 5:35 PM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger; Ananyev, Konstantin; Yigit, Ferruh
> > Subject: [PATCH v2] ixgbe: disable icc compile warning
> >
> > icc (icc (ICC) 16.0.1 20151021) is generating following compile error:
> > "
> > CC ixgbe_rxtx.o
> > .../drivers/net/ixgbe/ixgbe_rxtx.c(153): error #3656: variable
> > "free" may be used before its value is set
> > (nb_free > 0 && m->pool != free[0]->pool)) {
> > ^
> > "
> >
> > Indeed this is a false positive and code is correct.
> > "nb_free" check prevents the free[] access before its value set.
> >
> > Disabling this icc warning (#3656) for file ixgbe_rxtx.c.
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > drivers/net/ixgbe/Makefile | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> > index c032775..50bf51c 100644
> > --- a/drivers/net/ixgbe/Makefile
> > +++ b/drivers/net/ixgbe/Makefile
> > @@ -49,6 +49,8 @@ ifeq ($(CC), icc)
> > #
> > CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259
> >
> > +CFLAGS_ixgbe_rxtx.o += -wd3656
> > +
> > else ifeq ($(CC), clang)
> > #
> > # CFLAGS for clang
> > --
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
Applied to dpdk-next-net/rel_16_04
/Bruce
prev parent reply other threads:[~2016-03-25 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 17:45 [dpdk-dev] [PATCH] ixgbe: fix icc compile error Ferruh Yigit
2016-03-23 19:35 ` Stephen Hemminger
2016-03-23 21:26 ` Ferruh Yigit
2016-03-24 17:34 ` [dpdk-dev] [PATCH v2] ixgbe: disable icc compile warning Ferruh Yigit
2016-03-24 17:47 ` Ananyev, Konstantin
2016-03-25 13:57 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160325135729.GA14060@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).