* [dpdk-dev] [PATCH] bonding: fix initialisation of current_primary_port
@ 2016-03-23 17:30 Bernard Iremonger
2016-03-25 14:09 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: Bernard Iremonger @ 2016-03-23 17:30 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, michalx.k.jastrzebski, Bernard Iremonger
The current_primary_port is initialised to an invalid value
during bonded device creation.
It should be set to a valid value later.
This fix sets it to a valid value when the first slave port
is added to the bonding device.
Fixes: 2efb58cbab6e ("bond: new link bonding library")
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
drivers/net/bonding/rte_eth_bond_api.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c
index 3fca764..d473ac2 100644
--- a/drivers/net/bonding/rte_eth_bond_api.c
+++ b/drivers/net/bonding/rte_eth_bond_api.c
@@ -352,6 +352,7 @@ __eth_bond_slave_add_lock_free(uint8_t bonded_port_id, uint8_t slave_port_id)
/* Make primary slave */
internals->primary_port = slave_port_id;
+ internals->current_primary_port = slave_port_id;
/* Inherit queues settings from first slave */
internals->nb_rx_queues = slave_eth_dev->data->nb_rx_queues;
--
2.6.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] bonding: fix initialisation of current_primary_port
2016-03-23 17:30 [dpdk-dev] [PATCH] bonding: fix initialisation of current_primary_port Bernard Iremonger
@ 2016-03-25 14:09 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2016-03-25 14:09 UTC (permalink / raw)
To: Bernard Iremonger; +Cc: dev, ferruh.yigit, michalx.k.jastrzebski
On Wed, Mar 23, 2016 at 05:30:05PM +0000, Bernard Iremonger wrote:
> The current_primary_port is initialised to an invalid value
> during bonded device creation.
> It should be set to a valid value later.
> This fix sets it to a valid value when the first slave port
> is added to the bonding device.
>
> Fixes: 2efb58cbab6e ("bond: new link bonding library")
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net/rel_16_04
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-25 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-23 17:30 [dpdk-dev] [PATCH] bonding: fix initialisation of current_primary_port Bernard Iremonger
2016-03-25 14:09 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).