From: Bruce Richardson <bruce.richardson@intel.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] hash: fix typo in Doxygen comment
Date: Tue, 29 Mar 2016 17:03:05 +0100 [thread overview]
Message-ID: <20160329160304.GA15912@bricha3-MOBL3> (raw)
In-Reply-To: <1458829666-17285-1-git-send-email-pablo.de.lara.guarch@intel.com>
On Thu, Mar 24, 2016 at 02:27:46PM +0000, Pablo de Lara wrote:
> rte_hash_set_cmp_func() had an incorrect Doxygen comment
> for one of its parameters.
>
> Fixes: 95da2f8e9c61 ("hash: customize compare function")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> lib/librte_hash/rte_hash.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
> index 85fc416..add3414 100644
> --- a/lib/librte_hash/rte_hash.h
> +++ b/lib/librte_hash/rte_hash.h
> @@ -114,7 +114,7 @@ rte_hash_create(const struct rte_hash_parameters *params);
> * in multi-process mode.
> *
> * @param h
> - * Hash table to reset
> + * Hash table to change the function
Good idea to change this. However, to read correctly, I think it might need to
be adjusted slightly. E.g.
* Hash table for which the function is to be changed
* Hash table to update
Regards,
/Bruce
> * @param func
> * New compare function
> */
> --
> 2.5.5
>
next prev parent reply other threads:[~2016-03-29 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 14:27 Pablo de Lara
2016-03-29 16:03 ` Bruce Richardson [this message]
2016-03-29 17:38 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2016-04-01 12:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329160304.GA15912@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).