From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by dpdk.org (Postfix) with ESMTP id 84F462C4B for ; Wed, 30 Mar 2016 18:36:41 +0200 (CEST) Received: by mail-pa0-f49.google.com with SMTP id fe3so44952430pab.1 for ; Wed, 30 Mar 2016 09:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+remNRYk5wb1T1vHvBkPAhywtu7zK23MQcmHB9tUg1o=; b=wzYawLdKVMqDsnPb+cvxhsHUB5XXcR2NJOuYOAQCvaEP/nVA2qtlU3zEyEYVyzRVy0 C96DzQQj04SytZ30BOwYL+kN2r9INaV/qfWoWPNegmnUptG2Grav/hhHlMVi6gFqa1Ax vMIHcabYhb80Ra4pOU8x4pgVMJUd9wjxP3kHaIY2ygzRfjk4NCszC8vxdzr++0onVJrY I3x4hHRxrTK13YDuL9s06u/KSHqPuj+Al3OrtN4jO6w2+7eECI0tA/As3H+hcLd8DhM/ sw0KP6PK83gQSSKPp4h/9KpShoQvsEqRfWdD6y+vuzFMd4YqQ4ZTpMFMwCyjlpiKyJAK 19UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+remNRYk5wb1T1vHvBkPAhywtu7zK23MQcmHB9tUg1o=; b=ZGEDk0PYguV5Cjzf0a+0fJKhjY2RJHeEdOQd4nOmcKbZgWCUOk1MaJ0RgjiBXF5iI3 oatKGOV5dm5A1RyZLUP39WGdyPBYjRMBBFNKGzf+y/gp/A570j2UcxTPhpKn6aLDcLzB HBUODW4mI9qqJjTE96VbI2Gfy7/BjFiSCfBH0RV6vCAdfWPH/aOKLqGapsreMbOSFit1 c9YQ1Hc+HlPhPeHGXhX0/hZ6zJFLgi6YqyciM5d1jXHgKkGa1bZsl8nDDJHDDFh96Udo U1Dktc2acMp72bRJjZrixL8K2hFkEECLIH3ZMGVo9w/7QJlKoG7mQxF+Sbcq4LXeySpP ruCA== X-Gm-Message-State: AD7BkJJRFJfVF4yTbrqtJtbMabu7/h33VLRWxcAWyGo1kJZgsP0v8vQlLVoQjjHGXBJL2g== X-Received: by 10.66.197.132 with SMTP id iu4mr14590975pac.82.1459355800928; Wed, 30 Mar 2016 09:36:40 -0700 (PDT) Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net. [50.53.73.178]) by smtp.gmail.com with ESMTPSA id se8sm7111003pac.44.2016.03.30.09.36.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Mar 2016 09:36:40 -0700 (PDT) Date: Wed, 30 Mar 2016 09:36:53 -0700 From: Stephen Hemminger To: Aaron Conole Cc: Thomas Monjalon , Panu Matilainen , "Lu\, Wenzhuo" , dev@dpdk.org, "Richardson\, Bruce" Message-ID: <20160330093653.0d7e1847@xeon-e3> In-Reply-To: References: <1458682638-28378-1-git-send-email-aconole@redhat.com> <6A0DE07E22DDAD4C9103DF62FEBC09090343E973@shsmsx102.ccr.corp.intel.com> <56F38F26.1030707@redhat.com> <2113478.WYverkV2By@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/7] drivers/net/e1000: Suppress misleading indentation warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 16:36:41 -0000 On Wed, 30 Mar 2016 10:06:36 -0400 Aaron Conole wrote: > The register read/write mphy functions have misleading whitespace around > the `locked` check. This cleanup merely preserves the existing functionality > and suppresses future gcc versions' "misleading indentation" warning. > > Suggested-by: Panu Matilainen > Signed-off-by: Aaron Conole > --- > v2: > * Changed from "whitespace-only" fix to a functional change > moving the phy writes into protection of the `if (locked)` > code > * Added "Fixes" line. > > v3: > * Instead of changing the code, change to suppress the compiler warning > when using gcc6+. This was tested with both gcc6 and gcc5 using gnu > make 4.0 and gnu bash 4.3.42 on a fedora 23 system. > > drivers/net/e1000/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile > index ccd2b7b..f4879e6 100644 > --- a/drivers/net/e1000/Makefile > +++ b/drivers/net/e1000/Makefile > @@ -54,6 +54,9 @@ else > # > CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter > CFLAGS_BASE_DRIVER += -Wno-unused-variable > +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1) > +CFLAGS_BASE_DRIVER += -Wno-misleading-indentation > +endif > endif > > # NAK, don't do it to the whole file. Fix the code (best option) or use a pragma for the small area which is broken for other reasons.