From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id B560F2C4B for ; Wed, 30 Mar 2016 18:39:10 +0200 (CEST) Received: by mail-pf0-f169.google.com with SMTP id n5so47110470pfn.2 for ; Wed, 30 Mar 2016 09:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=klrs+U/tRWivTjtt+my3EYqzlRgiY6ztikL8QAhecYI=; b=UVLd8Mpcm5CAno/1302v8jTZJUkwzzb4EFdeRh4i3IrDBJx9hkIpiW3icNg+ZXs8bL n5HGIkhQy+v/8swvHFw6rZ4FTzEL9EZHiGp4RNT7PP/nNJUytxt9wArH63HOXnGwFmbI CR9u9jDDf6BlC3JTyyFQWSXeT6/ObFufpPrMnW82ewp2U9pul3nsp4LyshTqvsZVlJsH zCN1No/Qej+zBUxA7CGkASJwazAh2/7XQhM2bvU6LxmcGeiNTlvvB6Tv6QasERXjLMxX TPxp6bd5rN/x7GTg6x0YHr+mlqnnmWH6wYblmDcx82KGsf3CXfJjtlBgg3Cjv8Ike9Us USGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=klrs+U/tRWivTjtt+my3EYqzlRgiY6ztikL8QAhecYI=; b=P3euF/185fSTmf4+WttWUp7Ym6iMDlurciPezG3hPKBhR74uiRufo4mX6GPtnxXVyV 1C7HSkakYpChq7JbNmuWSHODPXctEfrtSbevJN/VQ+SDd4QIRE0wRDqsR3FsplnBJiXO UWBpDpD/x18H2AYFXHWRzRDrV/jQ3O8NfOLj4Z6yoIopY+fIz2eL8na9aqvl9635aDhE 8C97Djco8w7l0nAgRQmwz24m29DnAb5zjEDXbpmBmH2AKZ95Su9u/5vR55rsrCtRdMaJ zxDhVVI/MwVNR8261q9UQjlCwna5sSMxoNI5nnd11280BU15KBzRAGdADtO0h9AIhmFC mhgA== X-Gm-Message-State: AD7BkJLfS3TEILLpd3E57aVUQhFgk3PANS9Wfu+5qsaKk2gaahxUSrPGSi2i4X/7KYK4MA== X-Received: by 10.98.73.221 with SMTP id r90mr14728656pfi.70.1459355950106; Wed, 30 Mar 2016 09:39:10 -0700 (PDT) Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net. [50.53.73.178]) by smtp.gmail.com with ESMTPSA id h19sm7135479pfh.43.2016.03.30.09.39.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Mar 2016 09:39:09 -0700 (PDT) Date: Wed, 30 Mar 2016 09:39:26 -0700 From: Stephen Hemminger To: Rasesh Mody Cc: , , , , , Message-ID: <20160330093926.6bff277c@xeon-e3> In-Reply-To: <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com> References: <1459315705-25001-1-git-send-email-rasesh.mody@qlogic.com> <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 05/10] qede: Add core driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 16:39:11 -0000 On Tue, 29 Mar 2016 22:28:20 -0700 Rasesh Mody wrote: > + > +static void qede_print_adapter_info(struct qede_dev *qdev) > +{ > + struct ecore_dev *edev = &qdev->edev; > + struct qed_dev_info *info = &qdev->dev_info.common; > + char ver_str[QED_DRV_VER_STR_SIZE] = { 0 }; > + > + RTE_LOG(INFO, PMD, > + " Chip details : %s%d\n", > + ECORE_IS_BB(edev) ? "BB" : "AH", > + CHIP_REV_IS_A0(edev) ? 0 : 1); > + > + sprintf(ver_str, "%s %s_%d.%d.%d.%d", QEDE_PMD_VER_PREFIX, > + edev->ver_str, QEDE_PMD_VERSION_MAJOR, QEDE_PMD_VERSION_MINOR, > + QEDE_PMD_VERSION_REVISION, QEDE_PMD_VERSION_PATCH); > + strcpy(qdev->drv_ver, ver_str); > + RTE_LOG(INFO, PMD, " Driver version : %s\n", ver_str); > + > + ver_str[0] = '\0'; > + sprintf(ver_str, "%d.%d.%d.%d", info->fw_major, info->fw_minor, > + info->fw_rev, info->fw_eng); > + RTE_LOG(INFO, PMD, " Firmware version : %s\n", ver_str); > + > + ver_str[0] = '\0'; > + sprintf(ver_str, "%d.%d.%d.%d", > + (info->mfw_rev >> 24) & 0xff, > + (info->mfw_rev >> 16) & 0xff, > + (info->mfw_rev >> 8) & 0xff, (info->mfw_rev) & 0xff); > + RTE_LOG(INFO, PMD, " Management firmware version : %s\n", ver_str); > + > + RTE_LOG(INFO, PMD, " Firmware file : %s\n", QEDE_FW_FILE_NAME); This means the driver is far too chatty in the logs. Can't this be made DEBUG level?