From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com
 [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id F11C22BD9
 for <dev@dpdk.org>; Wed, 30 Mar 2016 18:41:06 +0200 (CEST)
Received: by mail-pf0-f171.google.com with SMTP id n5so47145234pfn.2
 for <dev@dpdk.org>; Wed, 30 Mar 2016 09:41:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Kr5lksD0c4BKcu6LOrQDQejMxB3z3uhJhJ3xox8NWJo=;
 b=NVudrxamSGOcwqroqJ5othKqnxQZkIJQqrxymVVU4K7n44zjv3YValUoH17IkuSPBj
 IZtS/vzU6EN/OVLPa4T6ccDrBbeMmNvSGBU2IWQkct+a9YXoGeHQFr2a4sK/N4q3+xTN
 WMMTXux5m3HXcHQ/6l/16yq3n6nDLrcxnD63b2cSdY5aJskExS5MDlg0CiG+Lst7Zosr
 xlj+jR01tnF0GZu59F1KoYvg9ELQ5PAiodNw+acqHXxOGUYny8/k+Y+9bWNqoH2f+CpG
 gi67ptM8UuoFCziqDv932oCz2MK43hVQgxn+imD7vHIRtTySnFyBU+Fv+bcLdC7aktSt
 9ArQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Kr5lksD0c4BKcu6LOrQDQejMxB3z3uhJhJ3xox8NWJo=;
 b=aK9BdRwPkfmz8puprWneUi6O1wB4MaNhgR6DAX+sn3gkDaIsJ3r2+1iuAxm2mT5ZcP
 xrcB/M6EwEre34aI7sEuKOgbKswHMoNo3O0mjE3F0r8uLdqzx5trlTdk2L7pIN+gdVVC
 4mp/9yR4jWvmHKKiXNNRQo1mnOg2TBxsfzLUvyPNq4Pr4DGI5M8klTcR/ho1+sYtt+0E
 2PaBzI2dX8kNG0YPFDgM1TxvsABQg+wCE6364Wdzua65PAAu4g4nTLdir5XpwLK7tZ1b
 t7idvkLyUvvApcFWuOURXr5wd1AnK6rtP8sNBawvMYg/CyRJzL4GJPxFEldPY3O5xns6
 9npg==
X-Gm-Message-State: AD7BkJL7FJyZNE87kqrcsqcM7i52eByTKal0sMKsNMNFYbfoDUHX8307aFVvr8YcvOX75A==
X-Received: by 10.98.40.4 with SMTP id o4mr14916762pfo.76.1459356066421;
 Wed, 30 Mar 2016 09:41:06 -0700 (PDT)
Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net.
 [50.53.73.178])
 by smtp.gmail.com with ESMTPSA id e1sm7189064pas.1.2016.03.30.09.41.05
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 30 Mar 2016 09:41:06 -0700 (PDT)
Date: Wed, 30 Mar 2016 09:40:29 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: <bruce.richardson@intel.com>, <thomas.monjalon@6wind.com>,
 <dev@dpdk.org>, <ameen.rahman@qlogic.com>, <harish.patil@qlogic.com>,
 <sony.chacko@qlogic.com>
Message-ID: <20160330094029.49117ab9@xeon-e3>
In-Reply-To: <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
References: <1459315705-25001-1-git-send-email-rasesh.mody@qlogic.com>
 <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 05/10] qede: Add core driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Mar 2016 16:41:07 -0000

On Tue, 29 Mar 2016 22:28:20 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +static void
> +qede_mac_addr_remove(__rte_unused struct rte_eth_dev *eth_dev,
> +		     __rte_unused uint32_t index)
> +{
> +	struct qede_dev *qdev = eth_dev->data->dev_private;
> +	struct ecore_dev *edev = &qdev->edev;
> +
> +	/* TBD: Not implemented currently because DPDK does not provide
> +	 * macaddr and instead just passes the index. So pmd needs to
> +	 * maintain index mapping to macaddr.
> +	 */
> +	DP_NOTICE(edev, false, "%s: Unsupported operation\n", __func__);
> +}
> +

Rather than have a stub and break software, why not just
not define the operation and let base DPDK handle the error?